{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":333423109,"defaultBranch":"main","name":"code-generator","ownerLogin":"aws-controllers-k8s","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2021-01-27T13:06:14.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/78112587?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1714682360.0","currentOid":""},"activityList":{"items":[{"before":"e168d489241ae30bc3af698936c039288c1c5d6f","after":null,"ref":"refs/heads/dependabot/go_modules/golang.org/x/net-0.23.0","pushedAt":"2024-05-02T20:23:00.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"dependabot[bot]","name":null,"path":"/apps/dependabot","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/29110?s=80&v=4"}},{"before":"d660ee36fe947607ebea039acd47c35477b4a836","after":"14cef51778d471698018b6c38b604181a6948248","ref":"refs/heads/main","pushedAt":"2024-05-02T20:22:14.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"ack-prow[bot]","name":null,"path":"/apps/ack-prow","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/260409?s=80&v=4"},"commit":{"message":"Pin ACK runtime to v0.34.0 (#528)\n\nBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.","shortMessageHtmlLink":"Pin ACK runtime to v0.34.0 (#528)"}},{"before":null,"after":"e168d489241ae30bc3af698936c039288c1c5d6f","ref":"refs/heads/dependabot/go_modules/golang.org/x/net-0.23.0","pushedAt":"2024-04-19T12:49:42.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"dependabot[bot]","name":null,"path":"/apps/dependabot","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/29110?s=80&v=4"},"commit":{"message":"Bump golang.org/x/net from 0.19.0 to 0.23.0\n\nBumps [golang.org/x/net](https://github.com/golang/net) from 0.19.0 to 0.23.0.\n- [Commits](https://github.com/golang/net/compare/v0.19.0...v0.23.0)\n\n---\nupdated-dependencies:\n- dependency-name: golang.org/x/net\n dependency-type: indirect\n...\n\nSigned-off-by: dependabot[bot] ","shortMessageHtmlLink":"Bump golang.org/x/net from 0.19.0 to 0.23.0"}},{"before":"37f4ba2b5a121a8786bc516e9ec4aa0b8b590c7d","after":"d660ee36fe947607ebea039acd47c35477b4a836","ref":"refs/heads/main","pushedAt":"2024-04-08T22:32:13.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"ack-prow[bot]","name":null,"path":"/apps/ack-prow","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/260409?s=80&v=4"},"commit":{"message":"Update base image to `eks-distro-minimal-base-nonroot:2024-04-01-1711929684.2` (#525)\n\nDodging CVE scanners before it's late :)\r\n\r\n\r\nBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.","shortMessageHtmlLink":"Update base image to `eks-distro-minimal-base-nonroot:2024-04-01-1711…"}},{"before":"e8df4d5a4b86dea0e227786c2c3d213e5aeda97a","after":"37f4ba2b5a121a8786bc516e9ec4aa0b8b590c7d","ref":"refs/heads/main","pushedAt":"2024-04-08T17:53:05.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"ack-prow[bot]","name":null,"path":"/apps/ack-prow","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/260409?s=80&v=4"},"commit":{"message":"Functionality to make `ignore` work (#464)\n\n**Issue** \r\nThis PR is related to fix the issue generating after executing PR #462 \r\n\r\n**Summary**\r\nTo disregard fields marked with `set: ignore` for nested fields. This PR also enhances the functionality of `set:ignore` to support the exclusion of fields from `set_sdk`.\r\n\r\n**Description**\r\n\r\nThe PR fixes the issue coming after a new custom field is created and has `set.ignore` set to `true` for it. Even after setting the field to ignore, the field is getting used to set the SDK fields. In this case particularly, the new field was defined as shown below:\r\n\r\n```\r\nCode.S3SHA256:\r\n type: string\r\n set: \r\n - method: Create\r\n ignore: true\r\n```\r\nAnd the issue it is causing is under `sdk.go/newCreateRequestPayload` function, where it is being set, as shown below:\r\n```\r\nif r.ko.Spec.Code.S3SHA256 != nil {\r\n\tf1.SetS3SHA256(*r.ko.Spec.Code.S3SHA256)\r\n}\r\n```\r\nThe goal is to ignore this particular line of code. And also to improve the basic functionality of `set.ignore`. \r\n\r\nThe `set.ignore` functionality was till now supporting exclusion of fields only when the field was used to set for the resource. \r\n\r\nThis PR checks the `set.ignore` for field and ignores the following code that creates request payload if it is set to `true`. \r\n\r\n**Limitations**\r\nCurrently this PR checks the `set.ignore` field only for members of the field whose type is `structure`. \r\n\r\n**Acknowledgment**\r\nBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.","shortMessageHtmlLink":"Functionality to make ignore work (#464)"}},{"before":"a0055e45082172ec6612d14ad17fe3504dd1b850","after":"e8df4d5a4b86dea0e227786c2c3d213e5aeda97a","ref":"refs/heads/main","pushedAt":"2024-03-29T14:09:15.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"ack-prow[bot]","name":null,"path":"/apps/ack-prow","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/260409?s=80&v=4"},"commit":{"message":"Pin ACK runtime to `v0.33.0` (#524)\n\nBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.","shortMessageHtmlLink":"Pin ACK runtime to v0.33.0 (#524)"}},{"before":"0bf780815ffcbcd447877f8b60d780489c6ae54c","after":"a0055e45082172ec6612d14ad17fe3504dd1b850","ref":"refs/heads/main","pushedAt":"2024-03-25T22:35:14.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"ack-prow[bot]","name":null,"path":"/apps/ack-prow","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/260409?s=80&v=4"},"commit":{"message":"Pin ACK pkg to `v0.0.12` (#523)\n\nBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.","shortMessageHtmlLink":"Pin ACK pkg to v0.0.12 (#523)"}},{"before":"ca5ff205b7be9c7fac8f35f8e7a3f6eae22af3ed","after":"0bf780815ffcbcd447877f8b60d780489c6ae54c","ref":"refs/heads/main","pushedAt":"2024-03-25T21:44:14.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"ack-prow[bot]","name":null,"path":"/apps/ack-prow","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/260409?s=80&v=4"},"commit":{"message":"feat(fieldpath): Handle case differences in structure member names (#522)\n\nThis patch updates the `memberShapeRef` function in the `fieldpath`\r\npackage to handle case differences between struct member names in the\r\nACK model and the AWS SDK Model.\r\n\r\nPreviously, the function assumed that member names in the ACK model and\r\nAWS SDK model were identical. However, this is not always the case, as\r\nsome field names may have different casing (e.g `AWSVPCConfiguration` in\r\nthe ACK model and `AwsVpcConfiguration` in the AWS SDK model).\r\n\r\nTo address this issue, the function now leverages `strings.EqualFold` to\r\ncompare the member names case isensitively.\r\n\r\nSigned-off-by: Amine Hilaly \r\n\r\nBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.","shortMessageHtmlLink":"feat(fieldpath): Handle case differences in structure member names (#522"}},{"before":"d2945bee6d92e678b7890820e4f48454c3bf2913","after":null,"ref":"refs/heads/dependabot/go_modules/google.golang.org/protobuf-1.33.0","pushedAt":"2024-03-14T01:33:14.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"dependabot[bot]","name":null,"path":"/apps/dependabot","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/29110?s=80&v=4"}},{"before":"af8006cb7248f0177e2a14b709c69c3a99a016ad","after":"ca5ff205b7be9c7fac8f35f8e7a3f6eae22af3ed","ref":"refs/heads/main","pushedAt":"2024-03-14T01:33:07.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"ack-prow[bot]","name":null,"path":"/apps/ack-prow","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/260409?s=80&v=4"},"commit":{"message":"Bump google.golang.org/protobuf from 1.31.0 to 1.33.0 (#521)\n\nBumps google.golang.org/protobuf from 1.31.0 to 1.33.0.\n\n\n[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)\n\nDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.\n\n[//]: # (dependabot-automerge-start)\n[//]: # (dependabot-automerge-end)\n\n---\n\n\nDependabot commands and options
\n
\n\nYou can trigger Dependabot actions by commenting on this PR:\n- `@dependabot rebase` will rebase this PR\n- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it\n- `@dependabot merge` will merge this PR after your CI passes on it\n- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it\n- `@dependabot cancel merge` will cancel a previously requested merge and block automerging\n- `@dependabot reopen` will reopen this PR if it is closed\n- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually\n- `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency\n- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)\n- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)\n- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)\nYou can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/aws-controllers-k8s/code-generator/network/alerts).\n\n ","shortMessageHtmlLink":"Bump google.golang.org/protobuf from 1.31.0 to 1.33.0 (#521)"}},{"before":null,"after":"d2945bee6d92e678b7890820e4f48454c3bf2913","ref":"refs/heads/dependabot/go_modules/google.golang.org/protobuf-1.33.0","pushedAt":"2024-03-13T23:23:54.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"dependabot[bot]","name":null,"path":"/apps/dependabot","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/29110?s=80&v=4"},"commit":{"message":"Bump google.golang.org/protobuf from 1.31.0 to 1.33.0\n\nBumps google.golang.org/protobuf from 1.31.0 to 1.33.0.\n\n---\nupdated-dependencies:\n- dependency-name: google.golang.org/protobuf\n dependency-type: indirect\n...\n\nSigned-off-by: dependabot[bot] ","shortMessageHtmlLink":"Bump google.golang.org/protobuf from 1.31.0 to 1.33.0"}},{"before":"a5ba3c851434263128a1464a2c41e528779eeefa","after":"af8006cb7248f0177e2a14b709c69c3a99a016ad","ref":"refs/heads/main","pushedAt":"2024-03-12T14:57:06.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"ack-prow[bot]","name":null,"path":"/apps/ack-prow","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/260409?s=80&v=4"},"commit":{"message":"Pin ACK pkg to v0.0.11 (#520)\n\nBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.","shortMessageHtmlLink":"Pin ACK pkg to v0.0.11 (#520)"}},{"before":"d5ae02a676f74fdc2d21511846054faee094ba48","after":"a5ba3c851434263128a1464a2c41e528779eeefa","ref":"refs/heads/main","pushedAt":"2024-03-06T21:21:32.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"ack-prow[bot]","name":null,"path":"/apps/ack-prow","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/260409?s=80&v=4"},"commit":{"message":"Correct helm resource MCR flags (#519)\n\n:hidding:, it looks like, i fat fingered before commit and the\r\n e2e tests didn't catch this typo...\r\n\r\nBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.","shortMessageHtmlLink":"Correct helm resource MCR flags (#519)"}},{"before":"39cb41ce03dce6f4c433a4268a2190a8df14d9eb","after":"d5ae02a676f74fdc2d21511846054faee094ba48","ref":"refs/heads/main","pushedAt":"2024-03-06T17:58:32.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"ack-prow[bot]","name":null,"path":"/apps/ack-prow","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/260409?s=80&v=4"},"commit":{"message":"Expose concurrent reconcile configuration flags in helm chart values (#517)\n\nThis patch adds configuration options for reconciler concurrency tuning\r\n (`reconcileDefaultMaxConcurrency` and `reconcileResourceMaxConcurrency`) \r\nin the Helm chart values, allowing users to customize reconciliation concurrency\r\nfor ACK service controllers deployed via Helm charts.\r\n\r\nBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.","shortMessageHtmlLink":"Expose concurrent reconcile configuration flags in helm chart values (#…"}},{"before":"0208d82b4fe1fa9b5902caae17112529d067eefd","after":"39cb41ce03dce6f4c433a4268a2190a8df14d9eb","ref":"refs/heads/main","pushedAt":"2024-03-06T15:53:32.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"ack-prow[bot]","name":null,"path":"/apps/ack-prow","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/260409?s=80&v=4"},"commit":{"message":"Fix comparison type mismatch in deployment template (#518)\n\nThis commit addresses the `incompatible types for comparison`\r\nerror ncountered during the deployment process (using helm).\r\nThe issue was caused by the incorrect comparison of a integer against a\r\nfloat\r\n\r\nThis patch fixesd the issues describe above by casting the\r\n`reconcile.defaultResyncPeriod` value to an integerer before performing\r\nthe comparison.\r\n\r\nSigned-off-by: Amine Hilaly \r\n\r\nBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.","shortMessageHtmlLink":"Fix comparison type mismatch in deployment template (#518)"}},{"before":"7f14b3299c887e5d4863459092b5b06a9ae44d3f","after":"0208d82b4fe1fa9b5902caae17112529d067eefd","ref":"refs/heads/main","pushedAt":"2024-03-05T01:21:08.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"ack-prow[bot]","name":null,"path":"/apps/ack-prow","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/260409?s=80&v=4"},"commit":{"message":"Pin ACK runtime to `v0.32.0` (#516)\n\nPropagating two main patches to all the controllers:\r\n- Properly handle CARM errors and requeues by @a-hilaly in https://github.com/aws-controllers-k8s/runtime/pull/140\r\n- Introduce flags for fine-tuning maximum concurrent reconciles per resource by @a-hilaly in https://github.com/aws-controllers-k8s/runtime/pull/141\r\n\r\nBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.","shortMessageHtmlLink":"Pin ACK runtime to v0.32.0 (#516)"}},{"before":"c2165b65565ab3a094cfb474c4396f4d14c7ef1e","after":"7f14b3299c887e5d4863459092b5b06a9ae44d3f","ref":"refs/heads/main","pushedAt":"2024-03-02T21:14:26.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"ack-prow[bot]","name":null,"path":"/apps/ack-prow","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/260409?s=80&v=4"},"commit":{"message":"Fixes Helm reference include reference (#515)\n\nIssue https://github.com/aws-controllers-k8s/community/issues/2029\r\n\r\nDescription of changes:\r\nFixed the reference by using `varIncludeTemplate`, so that the controller name is properly prefixed.\r\n\r\nGenerated ec2 controller code before:\r\n```\r\n{{/* The path the shared credentials file is mounted */}}\r\n{{- define \"ack-ec2-controller.aws.credentials.path\" -}}\r\n{{- printf \"%s/%s\" (include \"aws.credentials.secret_mount_path\" .) .Values.aws.credentials.secretKey -}}\r\n{{- end -}}\r\n```\r\nWhich resulted in:\r\n```\r\nError: template: ec2-chart/templates/deployment.yaml:112:20: executing \"ec2-chart/templates/deployment.yaml\" at : error calling include: template: ec2-chart/templates/_helpers.tpl:47:20: executing \"ack-ec2-controller.aws.credentials.path\" at : error calling include: template: no template \"aws.credentials.secret_mount_path\" associated with template \"gotpl\"\r\n```\r\n\r\nAfter:\r\n```\r\n{{/* The path the shared credentials file is mounted */}}\r\n{{- define \"ack-ec2-controller.aws.credentials.path\" -}}\r\n{{ $secret_mount_path := include \"ack-ec2-controller.aws.credentials.secret_mount_path\" . }}\r\n{{- printf \"%s/%s\" $secret_mount_path .Values.aws.credentials.secretKey -}}\r\n{{- end -}}\r\n```\r\nNow the template renders correctly.\r\n\r\nBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.","shortMessageHtmlLink":"Fixes Helm reference include reference (#515)"}},{"before":"2bb9266496138cbb71c6a4c845df5e5ca2fe5208","after":"c2165b65565ab3a094cfb474c4396f4d14c7ef1e","ref":"refs/heads/main","pushedAt":"2024-02-22T15:10:36.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"ack-prow[bot]","name":null,"path":"/apps/ack-prow","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/260409?s=80&v=4"},"commit":{"message":"Pin ACK runtime to `v0.31.0` (#514)\n\nPin ACK runtime to v0.31.0. Mainly addressing two github issues:\r\n- Healthz, liveness and readiness probes https://github.com/aws-controllers-k8s/community/issues/2012\r\n- CARM Race condition and scaling issues https://github.com/aws-controllers-k8s/community/issues/2011\r\n\r\nBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.","shortMessageHtmlLink":"Pin ACK runtime to v0.31.0 (#514)"}},{"before":"f0962135783a554bedb74e7cdf21723cfb501c93","after":"2bb9266496138cbb71c6a4c845df5e5ca2fe5208","ref":"refs/heads/main","pushedAt":"2024-02-19T21:55:29.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"ack-prow[bot]","name":null,"path":"/apps/ack-prow","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/260409?s=80&v=4"},"commit":{"message":"Extend `getAttributeFromPath` search to status fields as well. (#512)\n\nPrior to this patch, `getAttributeFromPath` searched for paths in spec\r\nfields only. And acted as a no-op when it comes to status fields. This\r\npatch extends the search to status fields as well, allowing us to\r\nconfigure nested fields in the status as well.\r\n\r\nThis is gonna be used to configure ECS Cluster `Status.Attachments.Type`\r\ngo tags (set `type` instead of `type_`)\r\n\r\nSigned-off-by: Amine Hilaly \r\n\r\nBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.","shortMessageHtmlLink":"Extend getAttributeFromPath search to status fields as well. (#512)"}},{"before":"ea8ce2d8e9cd3099fcc4841df23ddf0b04735f31","after":"f0962135783a554bedb74e7cdf21723cfb501c93","ref":"refs/heads/main","pushedAt":"2024-02-19T20:44:28.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"ack-prow[bot]","name":null,"path":"/apps/ack-prow","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/260409?s=80&v=4"},"commit":{"message":"Pin `github.com/aws-controllers-k8s/pkg` to v0.0.10 (#513)\n\nBringing `ACM` and `PCA` initialisms\r\n\r\nBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.","shortMessageHtmlLink":"Pin github.com/aws-controllers-k8s/pkg to v0.0.10 (#513)"}},{"before":"9c8a01fdcb2bcf7448cd9f9549c8b480e424e927","after":"ea8ce2d8e9cd3099fcc4841df23ddf0b04735f31","ref":"refs/heads/main","pushedAt":"2024-02-19T19:32:28.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"ack-prow[bot]","name":null,"path":"/apps/ack-prow","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/260409?s=80&v=4"},"commit":{"message":"Configure liveness and readiness probes for controller deployments (#508)\n\nPart of https://github.com/aws-controllers-k8s/community/issues/2012\r\n\r\nThis patch enhances controller availability by introducing liveness and\r\nreadiness probes. By configuring /healthz and /readyz endpoints for all\r\nthe controllers, the deployments can now effectively monitor their\r\nhealth status.\r\n\r\nWhile it's still a simple ping/pong healthz endpoints. We're laying the\r\nground for future more complex healthz and readiness checks. Thinking\r\nsomething like checking that the CARM informer health...\r\n\r\nSigned-off-by: Amine Hilaly \r\n\r\nBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.","shortMessageHtmlLink":"Configure liveness and readiness probes for controller deployments (#508"}},{"before":"ab21f459fb805ee7112a4033e3f50fa26f42c539","after":"9c8a01fdcb2bcf7448cd9f9549c8b480e424e927","ref":"refs/heads/main","pushedAt":"2024-02-18T19:44:34.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"ack-bot","name":"AWS Controllers for Kubernetes Bot","path":"/ack-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/82905295?s=80&v=4"},"commit":{"message":"[runtime builds] run `go mod tidy` before builds (#511)\n\nSigned-off-by: Amine Hilaly ","shortMessageHtmlLink":"[runtime builds] run go mod tidy before builds (#511)"}},{"before":"71c40be39876a83681066365c14ab4f258afba0d","after":"ab21f459fb805ee7112a4033e3f50fa26f42c539","ref":"refs/heads/main","pushedAt":"2024-02-18T19:27:07.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"ack-bot","name":"AWS Controllers for Kubernetes Bot","path":"/ack-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/82905295?s=80&v=4"},"commit":{"message":"[local builds] move instructions to copy code before go mod commands (#510)\n\nSigned-off-by: Amine Hilaly ","shortMessageHtmlLink":"[local builds] move instructions to copy code before go mod commands (#…"}},{"before":"f429bd95efc1c7286e7cc973dc174a30490a5521","after":"71c40be39876a83681066365c14ab4f258afba0d","ref":"refs/heads/main","pushedAt":"2024-02-18T17:19:11.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"ack-prow[bot]","name":null,"path":"/apps/ack-prow","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/260409?s=80&v=4"},"commit":{"message":"Simplify controllers local build system (#509)\n\n3 years ago we added a mechanism to build controllers using local module\r\nfiles for both `ack-generate`, controller binaries and container images.\r\nHowever, those turned out to be very complex to manage and more\r\nimportantly to maintain... the only use case we've seen over the years\r\nis the need to build a controller using a local runtime repository...\r\n\r\nNow that we want to start running e2e tests against runtime\r\nrepositories, we need a simplified way to build controller images using\r\nthe local runtime repository, only!\r\n\r\nThis patch removes all the never-used tooling around `go.local.mod` and\r\nkeeps `local-build-controller-image` for prow testing purposes.\r\n\r\nSigned-off-by: Amine Hilaly \r\nBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.","shortMessageHtmlLink":"Simplify controllers local build system (#509)"}},{"before":"fd54e0fd3994aae0da8268e459cd164d93ada69d","after":"f429bd95efc1c7286e7cc973dc174a30490a5521","ref":"refs/heads/main","pushedAt":"2024-02-17T00:21:06.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"ack-prow[bot]","name":null,"path":"/apps/ack-prow","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/260409?s=80&v=4"},"commit":{"message":"updating release script logic for olm flow to use cache director (#507)\n\nUpdating the logic in the OLM flow to use a the default cache directory.\r\n\r\nBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.","shortMessageHtmlLink":"updating release script logic for olm flow to use cache director (#507)"}},{"before":"d3ac622a24615621c147f8befc7280880adda630","after":"fd54e0fd3994aae0da8268e459cd164d93ada69d","ref":"refs/heads/main","pushedAt":"2024-02-16T22:22:06.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"ack-prow[bot]","name":null,"path":"/apps/ack-prow","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/260409?s=80&v=4"},"commit":{"message":"update OLM's manifest/bases/csv generation to use `ControllerName` (#506)\n\nIssue #, if available:\r\n- Relates: aws-controllers-k8s/community#2019\r\n\r\nDescription of changes:\r\nRecently `ControllerName` was introduced to allow controllers to have a custom, more user friendly name. This change caused the `/config/manifest/bases/.yaml` to be written to disk incorrectly for controllers that use the new `ControllerName` value. This change switches the `/config/manifest/bases/.yaml` to be written to disk so that OLM file/package generation can complete successfully and all of the proper values injected into the final `/bundle`.\r\n\r\nBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.","shortMessageHtmlLink":"update OLM's manifest/bases/csv generation to use ControllerName (#506"}},{"before":"947081ffebdeefcf2c61c4ca6d7e68810bdf9d08","after":"d3ac622a24615621c147f8befc7280880adda630","ref":"refs/heads/main","pushedAt":"2024-02-15T23:54:57.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"ack-prow[bot]","name":null,"path":"/apps/ack-prow","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/260409?s=80&v=4"},"commit":{"message":"Experimental configurations to override controller names (#494)\n\nSince the early days of ACK, we've always relied on the `serviceID` to\r\nname the controller repositories. The way names, go modules, import\r\npaths, helm charts are named relied on this `serviceID`. Which was the\r\nmain reason why some controllers had a bit of odd names, like\r\n`prometheusservice-controller` instead of `amp-controller`,\r\n`acmpca-controller` instead of `pca-controller`. This patch introduces\r\nexperimental configurations that instructs the code generator to\r\noverride the serviceID/servicePackageName when it comes to import\r\npaths/helm charts names etc...\r\n\r\nRelated issue: https://github.com/aws-controllers-k8s/community/issues/1411\r\n\r\nSigned-off-by: Amine Hilaly \r\n\r\nBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.","shortMessageHtmlLink":"Experimental configurations to override controller names (#494)"}},{"before":"0013c75d9939ec46dc6da3b94e3cd73c0b649e50","after":"947081ffebdeefcf2c61c4ca6d7e68810bdf9d08","ref":"refs/heads/main","pushedAt":"2024-02-14T03:48:30.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"ack-prow[bot]","name":null,"path":"/apps/ack-prow","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/260409?s=80&v=4"},"commit":{"message":"Pin `github.com/aws-controllers/runtime` to v0.30.0 (#505)\n\nBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.","shortMessageHtmlLink":"Pin github.com/aws-controllers/runtime to v0.30.0 (#505)"}},{"before":"3b621aa5580a69c58beee58a9ed63346716f347f","after":"0013c75d9939ec46dc6da3b94e3cd73c0b649e50","ref":"refs/heads/main","pushedAt":"2024-02-13T23:34:48.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"ack-prow[bot]","name":null,"path":"/apps/ack-prow","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/260409?s=80&v=4"},"commit":{"message":"Resolve conflicts in helm templates/values (#504)\n\nFixes: https://github.com/aws-controllers-k8s/community/issues/2014\r\n\r\nPrior to this patch, we observed some weird conflicts when installing multiple\r\nACK helm charts (as sub charts), e.g `ack-chart`, where the last controller\r\ninstallation would override values/templates from the previous ones.\r\nThis issue stemmed from the asumption that helm \"template\" names are\r\nunique across installations, which was a miss from the ACK team.\r\n\r\nThis patch addresses the conflict by prefixing all the helm template\r\nvariables with a `ack-$SERVICE-controller` string.\r\n\r\nThis solution comes with the cost of adding complexity to the already\r\ncomplex helm \"templates templates generator\"... However the least we\r\ncould do is to leverage Go template \"Funcs\" to reduce the complexity of\r\nwriting those templates. For example instead of writing something like\r\n`{{ \"{{ \\\"define \\\"ack- }}\" }}{{ .ServicePackageName }}{{\r\n\"-controller.rbac-rules\\\"\" }}`,\r\nwe could \"simply\" write a `{{ DefineTemplate \"rbac-rules\" }}`\r\n\r\nSigned-off-by: Amine Hilaly \r\n\r\nBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.","shortMessageHtmlLink":"Resolve conflicts in helm templates/values (#504)"}},{"before":"d349ee103d1f00672eea0685465d62d124957b8b","after":"3b621aa5580a69c58beee58a9ed63346716f347f","ref":"refs/heads/main","pushedAt":"2024-02-11T02:58:29.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"ack-prow[bot]","name":null,"path":"/apps/ack-prow","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/260409?s=80&v=4"},"commit":{"message":"Pin `github.com/aws-controllers-k8s/pkg` to v0.0.9 (#503)\n\nBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.","shortMessageHtmlLink":"Pin github.com/aws-controllers-k8s/pkg to v0.0.9 (#503)"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEQC9uQgA","startCursor":null,"endCursor":null}},"title":"Activity · aws-controllers-k8s/code-generator"}