Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MacrosExamples - ExecutionRoleBuilder update and typo #391

Open
Onolisk opened this issue Jul 4, 2023 · 2 comments
Open

MacrosExamples - ExecutionRoleBuilder update and typo #391

Onolisk opened this issue Jul 4, 2023 · 2 comments

Comments

@Onolisk
Copy link

Onolisk commented Jul 4, 2023

Hi, an update is required for the awslabs sample here:

https://github.com/awslabs/aws-cloudformation-templates/tree/master/aws/services/CloudFormation/MacrosExamples/ExecutionRoleBuilder

A simple typo in step 4 prevents inexperienced users from progressing. Python runtime to be updated 3.9 as the version specified is deprecated on AWS.

README.md

step 4:

OLD:

aws cloudformation deploy \
    --stack-name ExecutionRoleBuilderCFnMacro.packaged.template \
    --template-file ExecutionRoleBuilderCFnMacro \
    --capabilities CAPABILITY_IAM

NEW:

aws cloudformation deploy \
    --stack-name ExecutionRoleBuilderCFnMacro \
    --template-file ExecutionRoleBuilderCFnMacro.packaged.template  \
    --capabilities CAPABILITY_IAM

macro.template:

Transform: AWS::Serverless-2016-10-31
Resources:
  Function:
    Type: AWS::Serverless::Function
    Properties:
      Runtime: python3.9
Copy link

Due to inactivity this issue will be closed in 7 days

@ericzbeard
Copy link
Contributor

Keep this open until we decide where the macro examples will live.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants