Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authenticator error message overflows if message is long #5232

Open
4 tasks done
esauerbo opened this issue May 9, 2024 · 2 comments
Open
4 tasks done

Authenticator error message overflows if message is long #5232

esauerbo opened this issue May 9, 2024 · 2 comments
Labels
Authenticator An issue or a feature-request for an Authenticator UI Component bug Something isn't working CSS Bugs or features related to CSS

Comments

@esauerbo
Copy link
Contributor

esauerbo commented May 9, 2024

Before creating a new issue, please confirm:

On which framework/platform are you having an issue?

React, Angular, Vue, React Native

Which UI component?

Authenticator, Primitive components

How is your app built?

next

What browsers are you seeing the problem on?

No response

Which region are you seeing the problem in?

No response

Please describe your bug.

If a long string is passed as an error message to the authenticator, the message will overflow outside of the container.

e.g.:
Screenshot 2024-05-09 at 11 37 01 AM

What's the expected behaviour?

The text should fit inside of the error container. One way would be to break up the string onto multiple lines, or the container could be made scrollable.

Help us reproduce the bug!

Hardcode a long string into the authenticator error message on any framework. E.g. on react, replace the translate(error) with a string here. Then force a form validation error by typing in an invalid email/password combo.

Code Snippet

// Put your code below this line.

Console log output

No response

Additional information and screenshots

No response

@github-actions github-actions bot added the pending-triage Issue is pending triage label May 9, 2024
@esauerbo esauerbo added bug Something isn't working Authenticator An issue or a feature-request for an Authenticator UI Component CSS Bugs or features related to CSS and removed pending-triage Issue is pending triage labels May 9, 2024
@reesscot
Copy link
Contributor

reesscot commented May 10, 2024

@esauerbo This would only occur if there's a really long word in a paragraph, right?

@esauerbo
Copy link
Contributor Author

@esauerbo This would only occur if there's a really long word in a paragraph, right?

@reesscot I was only able to reproduce with a really long word; multiple words were split onto new lines. But the error message from #5225 had whitespace that wasn't broken onto new lines, so we'll need to look into what happened there as well.
Screenshot 2024-05-10 at 9 51 04 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Authenticator An issue or a feature-request for an Authenticator UI Component bug Something isn't working CSS Bugs or features related to CSS
Projects
None yet
Development

No branches or pull requests

2 participants