Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visual inconsistencies across buttons widths, font weights, casing #5156

Open
4 tasks done
jxdp opened this issue Apr 12, 2024 · 2 comments
Open
4 tasks done

Visual inconsistencies across buttons widths, font weights, casing #5156

jxdp opened this issue Apr 12, 2024 · 2 comments
Labels
Authenticator An issue or a feature-request for an Authenticator UI Component bug Something isn't working CSS Bugs or features related to CSS

Comments

@jxdp
Copy link

jxdp commented Apr 12, 2024

Before creating a new issue, please confirm:

On which framework/platform are you having an issue?

React

Which UI component?

Authenticator

How is your app built?

Next.js

What browsers are you seeing the problem on?

Chrome, Safari

Which region are you seeing the problem in?

No response

Please describe your bug.

Visual inconsistencies between the different screens. In particular:

  1. the Sign In and Sign Up screens have bold text in their main button, but the Forgot Password screens don't

    • this looks to be a very easy fix, namely just removing fontweight="normal" from the two-button layout component
  2. the Sign In screen bottom button ("Forgot your password?") is not full-width, but the "Back to Sign In" and "Request another code" buttons on the Forgot Password screen are full width

  3. the Header text for the "Force New Password" and "Forgot Password" are inexplicably different sizes

    • these can be overridden (which is presumably what everyone does, because they're unthinkably bad), so not as problematic.

These are small things but they really do stand out in practice--the experience should not vary so much between screens.

Fortunately, these are very easily solvable.

What's the expected behaviour?

I would expect things like font weights, button widths, font sizes, etc. to be consistent. Visual consistency matters, and signing up is often one of the first experiences a customer has.

Help us reproduce the bug!

Couldn't be easier -- just look at it!

https://ui.docs.amplify.aws/react/connected-components/authenticator

Code Snippet

// Put your code below this line.

Console log output

No response

Additional information and screenshots

Different font weight in main buttons + Different width bottom buttons

Main button bold, Bottom button not full width

image

Main button not bold, Bottom button full width

image

Inconsistent casing

Sign in (see above) vs Create Account

image

This one is double frustrating because it is written Sign In everywhere else. The submit button is inexplicably different.

@github-actions github-actions bot added the pending-triage Issue is pending triage label Apr 12, 2024
@hbuchel hbuchel added bug Something isn't working Authenticator An issue or a feature-request for an Authenticator UI Component CSS Bugs or features related to CSS and removed pending-triage Issue is pending triage labels Apr 15, 2024
@esauerbo
Copy link
Contributor

esauerbo commented May 8, 2024

@jxdp thanks for creating this issue. Regarding the casing inconsistencies, you can customize the 'Sign in' text (or the labels and text of any component for that matter) using the I18n module. For your specific case that would look like this:

import { I18n } from 'aws-amplify/utils';
I18n.putVocabularies({
  en: {
    'Sign in': 'Sign In',
  },
});

Changing the casing of the text is considered a breaking change, which we try to avoid introducing outside of major version bumps. We're continuing to look into the styling issues, but hope this helps!

@jxdp
Copy link
Author

jxdp commented May 10, 2024

@jxdp thanks for creating this issue. Regarding the casing inconsistencies, you can customize the 'Sign in' text (or the labels and text of any component for that matter) using the I18n module. For your specific case that would look like this:

import { I18n } from 'aws-amplify/utils';
I18n.putVocabularies({
  en: {
    'Sign in': 'Sign In',
  },
});

Changing the casing of the text is considered a breaking change, which we try to avoid introducing outside of major version bumps. We're continuing to look into the styling issues, but hope this helps!

Thanks @esauerbo, I have been using the I18n module to overcome the casing inconsistencies. Hoping to see the styles fixed in an upcoming update!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Authenticator An issue or a feature-request for an Authenticator UI Component bug Something isn't working CSS Bugs or features related to CSS
Projects
None yet
Development

No branches or pull requests

3 participants