Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS 13 Memory Issue #31

Open
AvdLee opened this issue Nov 4, 2019 · 4 comments
Open

iOS 13 Memory Issue #31

AvdLee opened this issue Nov 4, 2019 · 4 comments

Comments

@AvdLee
Copy link
Contributor

AvdLee commented Nov 4, 2019

We can see a crash in our crash reports regarding Memory, happening in the AssetsGridViewController and 100% on iOS 13.

We still need to look into it but I have the feeling that this is caused by loading the previews for the first time, filling up the memory.

Any ideas?

@terhechte
Copy link

@AvdLee Did you ever find a solution for this Antoine?

@AvdLee
Copy link
Contributor Author

AvdLee commented Dec 16, 2019

in our app it turned out to be related to another retain cycle as we didn't capture the new drag down dismiss for the new iOS 13 sheet presentation style.

I'm not entirely sure whether the original description is still an issue. Do you experience the same?

@terhechte
Copy link

No, I was pondering using this library as most of the other open source solutions for multi-selection of images did not meet my requirements. However I've started using it now and so far it looks good. :)

@AvdLee
Copy link
Contributor Author

AvdLee commented Dec 16, 2019

@terhechte awesome! Yeah, we're using it in the WeTransfer app and it has since not let us down 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants