Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github actions improvement #1679

Open
mcuee opened this issue Feb 7, 2024 · 8 comments
Open

github actions improvement #1679

mcuee opened this issue Feb 7, 2024 · 8 comments
Labels
enhancement New feature or request

Comments

@mcuee
Copy link
Collaborator

mcuee commented Feb 7, 2024

  1. Apple Silicon macOS build -- we have to wait github infrastructure to be ready first
  1. Deploy action -- to include MSYS2 mingw64/mingw32 binaries upon formal release like 7.3.

  2. Deploy action for Arduino-packing github action upon formal release like 7.3.

  3. It may be good to add github actions for BSDs.

@mcuee mcuee added the enhancement New feature or request label Feb 7, 2024
@mcuee
Copy link
Collaborator Author

mcuee commented Feb 7, 2024

Deploy action -- to include MSYS2 mingw64/mingw32 binaries upon formal release like 7.3.

Currently the deploy github action only upload Windows MSVC binaries.
https://github.com/avrdudes/avrdude/blob/main/.github/workflows/deploy.yml
https://github.com/avrdudes/avrdude/actions/runs/7813933855

The mingw32/mingw64 github action binaries will not have the correct version number, but rather one commit after.

Edit: the above deploy github action does build MSYS2 mingw32/mingw64/clang32/clang64/ucrt64 binaries for avrdude 7.3 release. So we can decide whether to upload them or not.

@mcuee
Copy link
Collaborator Author

mcuee commented Feb 7, 2024

As for the binaries generated by arduino-packing script, as of now, the script does not deal with releases yet.So the version number will not matching -- one commit after the release tag.
https://github.com/avrdudes/avrdude/blob/main/.github/workflows/arduino_packing.yml

@umbynos
The avrdude-packing script in this repo is a cut-down version of your more detailed script. One missing feature is to deal with the tagged release (say 7.3 release). Just wondering if you can help here. Thanks.

@umbynos
Copy link
Contributor

umbynos commented Feb 9, 2024

Hey @mcuee what do you mean by this?

One missing feature is to deal with the tagged release (say 7.3 release).

@mcuee
Copy link
Collaborator Author

mcuee commented Feb 9, 2024

@umbynos

As of now, the action is only executed upon git push to git main, but not release tagging.
https://github.com/avrdudes/avrdude/blob/main/.github/workflows/arduino_packing.yml

Your original version is okay but I do not know how to adapt it to avrdude git main.
https://github.com/arduino/avrdude-packing/blob/main/.github/workflows/release.yml

@mcuee
Copy link
Collaborator Author

mcuee commented Feb 17, 2024

@mcuee
Copy link
Collaborator Author

mcuee commented Feb 17, 2024

As of now, the action is only executed upon git push to git main, but not release tagging.
https://github.com/avrdudes/avrdude/blob/main/.github/workflows/arduino_packing.yml

@umbynos
I have created a new PR to address the above issue. But I am not so sure if this is the right solution or not. Please review. Thanks.

@ndim
Copy link
Contributor

ndim commented Feb 20, 2024

  1. It may be good to add github actions for BSDs.

GitHub only has Ubuntu, Windows and OSX workers.

However, Cirrus CI has a free offer for Open Source Projects which includes CI builds on FreeBSD.

@mcuee
Copy link
Collaborator Author

mcuee commented Feb 20, 2024

  1. It may be good to add github actions for BSDs.

GitHub only has Ubuntu, Windows and OSX workers.

However, Cirrus CI has a free offer for Open Source Projects which includes CI builds on FreeBSD.

There are some changes now. Please refer to the following discussions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants