Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Easier contributions for distros #16

Open
rugk opened this issue May 26, 2019 · 3 comments
Open

Easier contributions for distros #16

rugk opened this issue May 26, 2019 · 3 comments

Comments

@rugk
Copy link
Contributor

rugk commented May 26, 2019

If I want to fix about a distro, it seems I have to dig into this file: librehunt.js

Then all I see is just a big file with binary options in an array. I have no idea what aligns to which option, what I have to change to check it etc. (sorry, but here are really some code quality improvements, needed)

Please ease contributions! This needs some contributing doc, and preferably a different format (JSON?).
And explanations for each option.

@aviwad
Copy link
Owner

aviwad commented May 26, 2019

About this. LibreHunt was originally server side python code, which was admittedly less clumsy and uglier than this shitstorm of a code. Originally, I just wanted to convert my server side website to github based in a day, hence the crappy coding. I'll certainly look into making the code more readable, efficient, and clean (also documentation)

@aviwad
Copy link
Owner

aviwad commented May 29, 2019

#25 for using JSON, and I am currently working on changing the last two lines of librehunt.js that add all the html to be on separate lines and include comments too!

aviwad added a commit that referenced this issue May 29, 2019
html lines in librehunt.js now cleaner, in separate lines, and given comments
aviwad added a commit that referenced this issue Jun 3, 2019
a shit ton of work YEET
@aviwad
Copy link
Owner

aviwad commented Jun 3, 2019

all that's left for this issue is some contributing guide or something, which i'll work on in a few days

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants