Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fallback samples_dir to current directory if the configuration is not set #140

Open
MatejKastak opened this issue Oct 23, 2023 · 1 comment

Comments

@MatejKastak
Copy link
Member

Thanks to suggestions from @ruppde , I realized that it would be a nice default to fallback and search for the samples in the folder with the currently opened file.

I am currently not sure how to implement this, since I believe that we can't just use ., because it might not work in every scenario.

But we might be able to extract this information from currently opened Document.

@ruppde
Copy link
Contributor

ruppde commented Oct 23, 2023

Good idea to use the folder of the .yar because of the vscode structure, you might have different . directories.

The perfect solution would be, to use something like https://github.com/mruffalo/hash-db and regularly create a database of hashes and filepaths, which could then be used. Would allow to keep the rules separated from the samples.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants