Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHubReleasesInfoProvider additional functionality - raise a warning if a repo has been archived or disabled. #934

Open
paul-cossey opened this issue Feb 8, 2024 · 2 comments

Comments

@paul-cossey
Copy link

Describe the problem

More a feature request than a problem... raising following a conversation in MacAdmins Slack

GitHubReleasesInfoProvider does not raise a warning or error if a repo has been archived or disabled. If the media is still available, recipes will complete successfully, and admins have no way of knowing the project state unless there is a manual check.

Preferences contents
N/A

AutoPkg output
N/A

Expected behaviour

If GitHubReleasesInfoProvider detects that a repo is either "archived": true, or "disabled": true, it should raise a warning to inform the admin that investigation is need.

Version (please complete the following information):

  • OS version: N/A
  • AutoPkg Version: N/A
@nmcspadden
Copy link
Contributor

So I'd propose:

  1. if the repo is archived or disabled, the processor should fail by default;
  2. allow an input variable to override that behavior and ignore the archive/disable flag and use it anyway

It's still potentially useful to run an autopkg recipe against an old repo, just to simplify the effort of manually importing a software release from it. So admins who wish to do so can intentionally opt-in via their override.

@paul-cossey
Copy link
Author

Thanks, Nick.

That would be ideal for us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants