Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generating the Recipe Map for the first time is very slow #932

Open
n8felton opened this issue Feb 6, 2024 · 0 comments
Open

Generating the Recipe Map for the first time is very slow #932

n8felton opened this issue Feb 6, 2024 · 0 comments

Comments

@n8felton
Copy link
Member

n8felton commented Feb 6, 2024

This appears to mostly be related to the get_git_commit_hash() function. As of right now, this hash is not actively being added to, or used by, the recipe map, so I'm proposing that it be bypassed during the recipe map generation.

Small comparison

With get_git_commit_hash() function

com.github.autopkg.n8felton-recipes
Function map_key_to_paths('identifiers', 'com.github.autopkg.n8felton-recipes') Took 6.1634 seconds
Function map_key_to_paths('shortnames', 'com.github.autopkg.n8felton-recipes') Took 5.9794 seconds
com.github.autopkg.recipes
Function map_key_to_paths('identifiers', 'com.github.autopkg.recipes') Took 8.5584 seconds
Function map_key_to_paths('shortnames', 'com.github.autopkg.recipes') Took 8.7585 seconds
com.github.autopkg.dataJAR-recipes
Function map_key_to_paths('identifiers', 'com.github.autopkg.dataJAR-recipes') Took 79.9220 seconds
Function map_key_to_paths('shortnames', 'com.github.autopkg.dataJAR-recipes') Took 81.3130 seconds

Without get_git_commit_hash() function

com.github.autopkg.n8felton-recipes
Function map_key_to_paths('identifiers', 'com.github.autopkg.n8felton-recipes') Took 0.1235 seconds
Function map_key_to_paths('shortnames', 'com.github.autopkg.n8felton-recipes') Took 0.1107 seconds
com.github.autopkg.recipes
Function map_key_to_paths('identifiers', 'com.github.autopkg.recipes') Took 0.2013 seconds
Function map_key_to_paths('shortnames', 'com.github.autopkg.recipes') Took 0.1758 seconds
com.github.autopkg.dataJAR-recipes
Function map_key_to_paths('identifiers', 'com.github.autopkg.dataJAR-recipes') Took 1.2155 seconds
Function map_key_to_paths('shortnames', 'com.github.autopkg.dataJAR-recipes') Took 1.0574 seconds

References:
#931
https://macadmins.slack.com/archives/C056155B4/p1706411010531239

n8felton added a commit to n8felton/autopkg that referenced this issue Feb 6, 2024
n8felton added a commit to n8felton/autopkg that referenced this issue Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In review
Development

No branches or pull requests

1 participant