MunkiOptionalReceiptEditor.py Failure When MunkiImporter Doesn't Import an Item

[foigus]

Original discussion here.

Examining the python code seems to say that Sam Keeley's MunkiPkginfoReceiptsEditor.py just exits when no pkginfo_repo_path is supplied:

       if len(self.env['pkginfo_repo_path']) < 1:
            self.output('empty pkginfo path')
            return

whereas the core MunkiOptionalReceiptEditor.py fails when no pkginfo_repo_path is supplied:

    def main(self):
        if len(self.env["pkginfo_repo_path"]) < 1:
            raise ProcessorError("You must specify at least one pkginfo repo path")

• pkginfo_repo_path is required by both processors
• It's reasonable to return a processor error when a required variable isn't passed into the processor
• However pkginfo_repo_path is set to empty if MunkiImporter.py doesn't import an item
• Not importing an item is arguably the most common case when using .munki recipes

It's reasonable for recipe authors to not need to check for munki_repo_changed being set to False and halt recipe execution purely because there was no import of an item into the Munki repo (example here).

Possible solutions:

• Make pkginfo_repo_path not required
• Assuming this processor is supposed to run after MunkiImporter, exit the processor with a no-op if pkginfo_repo_path is Empty

[nmcspadden]

Should be fixed in the dev branch with bf9fa41.

[MScottBlake]

Is there a timeframe where we should expect this fix to be merged into master?