Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

primary feature gives advices to add already added dependencies #1134

Open
BraisGabin opened this issue Feb 19, 2024 · 1 comment
Open

primary feature gives advices to add already added dependencies #1134

BraisGabin opened this issue Feb 19, 2024 · 1 comment
Labels
bug Something isn't working toolchain:java
Milestone

Comments

@BraisGabin
Copy link
Contributor

BraisGabin commented Feb 19, 2024

Plugin version
1.30.0 (but it was present before too)

Gradle version
8.6

JDK version
17

(Optional) Kotlin and Kotlin Gradle Plugin (KGP) version
1.9.22

(Optional) Android Gradle Plugin (AGP) version
8.2.2

Describe the bug
I have a project like this: consumer -> unused -> used and consumer only uses :used (this is not important, if consumer uses both the problem is still there). And a bundle like this:

bundle('facade') {
  includeDependency(':unused')
  includeDependency(':used')
}

I expect not advices. And that works! But when I change the bundle to this:

bundle('facade') {
  primary(':unused')
  includeDependency(':used')
}

I also expect not advices but I get an advice telling me that :consumer should depend on :unused. But :consumer already depends on :unused so the advice shouldn't exist

To Reproduce
Steps to reproduce the behavior:

  1. Go to src/functionalTest/groovy/com/autonomousapps/jvm/projects/BundleProject2.groovy and edit the line 31 from includeDependency to primary
  2. Run the test

Expected behavior
No advices

@autonomousapps autonomousapps added the bug Something isn't working label Feb 22, 2024
@autonomousapps autonomousapps added this to the next milestone Feb 22, 2024
@autonomousapps
Copy link
Owner

Thanks for the report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working toolchain:java
Projects
None yet
Development

No branches or pull requests

2 participants