Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce Integer Constraints in Integer Hyperparameter Search Space Definition #32

Open
TarekAbouChakra opened this issue Nov 14, 2023 · 0 comments
Labels
question Further information is requested

Comments

@TarekAbouChakra
Copy link
Collaborator

class IntegerParameter(FloatParameter):
def __init__(
self,
lower: float | int,
upper: float | int,

The IntegerParameter class currently extends FloatParameter, allowing float numbers to be passed in instances where the intention is to define an integer hyperparameter search space. Although this is dealt with internally by rounding, should users be allowed to pass in floats when defining integers in the search spaces ?

@TarekAbouChakra TarekAbouChakra added the question Further information is requested label Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant