Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor documentation fixes #109

Open
theodorju opened this issue Jan 11, 2022 · 0 comments
Open

Minor documentation fixes #109

theodorju opened this issue Jan 11, 2022 · 0 comments

Comments

@theodorju
Copy link

Hi, all

I've been reading the documentation and had the following findings in the code for [this] (https://automl.github.io/HpBandSter/build/html/auto_examples/example_5_pytorch_worker.html) example. More specifically:

  • The loss is set equal to zero at the start of the for-epochs loop, but later it is re-calculated from the start The loss=0 statement right after the for-epochs loop could be removed.
  • Criterion is set equal to criterion = torch.nn.CrossEntropyLoss() but then it is never used.
  • Function evaluate_accuracy has an import pdb statement commented out. Not sure if this is intended.
  • Function compute has a # device = torch.device('cpu') statement commented out. Not sure if this is intended.

Additionally in this example the line inc_run.info['test accuracy'] should be replaced with inc_run.info['test_accuracy'] (underscore needs to be added).

I would like to work on fixing these minor changes as soon as I have some time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant