Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Varying configspace index order in PDP and symbolic explanations #111

Open
sarah-segel opened this issue Feb 9, 2024 · 1 comment
Open
Labels
bug Something isn't working
Milestone

Comments

@sarah-segel
Copy link
Contributor

sarah-segel commented Feb 9, 2024

In the PDP plugin (similar in symbolic expl), the configspace is copied when creating the surrogate model
surrogate_model = RandomForestSurrogate(run.configspace, seed=0)
and also when creating the PDP
pdp = PDP.from_random_points(

In rare cases, this copying of the config space can lead to a different index order in the configspace. This is problematic, as we get the index of the selected hyperparameters from the original configspace, but then use it to select the correct index from the data produced by the PDP (with the changed index).

For example, this occurs when using the run logs/SMAC3v1/outlier-detection/DEHB-pendigits-015-0-0 with
hyperparameter_name_1="backbone:num_latent_units"
to calculate the PDP.

@sarah-segel sarah-segel added the bug Something isn't working label Feb 9, 2024
@sarah-segel sarah-segel added this to the v2.0 milestone Feb 9, 2024
@alexandertornede
Copy link
Contributor

This seems to be caused by a faulty copy functionality of the underlying PDP package we are using. I reported the issue: dwoiwode/py-pdp-partitioner#6

alexandertornede added a commit that referenced this issue Feb 22, 2024
…related to copying config space objects (closes #111)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants