Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add precommit checking for code style #44

Merged
merged 4 commits into from
Jul 22, 2023
Merged

Add precommit checking for code style #44

merged 4 commits into from
Jul 22, 2023

Conversation

Bronzila
Copy link
Collaborator

This is currently marked as a draft, since we are not yet adhering to the style guidelines. However I still think it is an good idea to include it, so that we can at least check, that we do not add more style-errors.

Bronzila and others added 2 commits July 11, 2023 11:28
No file changes have yet been done and committed, waiting for approval.
Get branch up to date with development
@Bronzila Bronzila marked this pull request as draft July 20, 2023 11:39
@Bronzila Bronzila requested a review from Neeratyoy July 20, 2023 11:39
.pre-commit-config.yaml Outdated Show resolved Hide resolved

- repo: https://gitlab.com/pycqa/flake8
rev: 4.0.1
- id: ruff
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥂

pyproject.toml Outdated Show resolved Hide resolved
- id: flake8
name: flake8 tests
files: tests
- id: black
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏🏽

Copy link
Collaborator

@Neeratyoy Neeratyoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guess we just merge this and iterate, right?
If so, please go ahead and merge it after Eddie's comments are accounted for!

@Bronzila Bronzila marked this pull request as ready for review July 22, 2023 09:59
@Bronzila Bronzila changed the title Draft: Add precommit checking for code style Add precommit checking for code style Jul 22, 2023
@Bronzila Bronzila merged commit 8b6d373 into development Jul 22, 2023
13 of 15 checks passed
@Bronzila Bronzila linked an issue Jul 24, 2023 that may be closed by this pull request
@Bronzila Bronzila deleted the precommit branch July 29, 2023 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve doc strings and add type annotations
3 participants