Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for tokio runtime metrics #59

Closed
wants to merge 1 commit into from
Closed

Add support for tokio runtime metrics #59

wants to merge 1 commit into from

Conversation

gagbo
Copy link
Member

@gagbo gagbo commented Apr 3, 2023

Tokio runtime metrics

Add support for adding unstable tokio runtime metrics to the prometheus export.

Closes: #57

@gagbo
Copy link
Member Author

gagbo commented Apr 3, 2023

The main open questions here are:

  • Should we add pre-made prometheus queries and links for tokio runtime metrics? Which ones?
  • Where should this section be added, since it's a "global" metric not linked to a function?
  • Is the current feature set to trigger the option ok?

I also probably want to add at least a compile test in the CI to check that the feature flags work correctly

@emschwartz
Copy link
Contributor

I think we can close this PR for now. We may want to revisit automatically collecting runtime metrics in the future.

@emschwartz emschwartz closed this Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorporate tokio-metrics.
2 participants