🔧 Set different CHMOD_VALUE setting for files and directories

[xieve]

Is this feature missing in the latest version?

• I'm using the latest release

Is your feature request related to a problem? Please describe.

I'm running the ARM docker image on Unraid, and I want all directories to consistently have their permissions set to 777, and files to 666. The reason is that the files that ARM puts out are never executables and I do not want them marked as such.

Describe the solution you'd like?

Introduce a new option called CHMOD_DIRECTORIES or similar, that defaults to the value of CHMOD_VALUE, but if set makes it possible to have different permissions for files and directories.

Describe alternatives you've considered?

You could simply remove the executable bit from any mask specified in CHMOD_VALUE for files, because there is really no reason to set it afaik.

A much worse alternative would be writing a script that is either called through the BASH_SCRIPT parameter or by inotifywait and corrects this issue externally.

Anything else?

The code of conduct link in this issue template is broken.

Code of Conduct

• I agree to follow this project's Code of Conduct

[github-actions]

If youre having issues, please remember to read the wiki and follow the instructions carefully

[AD-Wright]

I would also appreciate this! I have arm put the files on a NAS, and as the permissions are currently set, I can read all the files from another computer, so I can copy them off, sort/transcode them manually, and then move the transcoded files into my media library. However, I cannot then delete the ripped files without logging in as root or arm on the device running arm. It seems like 777 for directories (or even 775, rather than the current 755) would resolve this. Files seem to already be marked as 666.
Or maybe I'm missing something else.

[brandonp42]

Same issue here - the default 755 for directories is annoying. I looked into this and found a PR that was merged in June 2022 to help with this (see #513) but the code seems missing - I couldn't tell if it was intentionally removed again or if it was an inadvertent change when merging another branch into main.

[microtechno9000]

Looking at the code, UMASK is still in the arm.yml but appears to have been removed from the ripper code. Going back through what I can see, I am unsure why and what commit. There has been a lot of work on ARM between Jun 22 and now, and a few re-writes of portions of code. I looks like it was just lost.

If the code in #513 would resolve it, let me know and I can put it back in

[brandonp42]

I ran a test this morning manually changing the code in my ARM container and it worked great, please put it back in. I did have to change it a little, apparently any cfg["UMASK"] references now need to be cfg.arm_config["UMASK"]