Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[smell] circular imports on frontend #1408

Open
ghost opened this issue Feb 14, 2024 · 1 comment · May be fixed by #1415
Open

[smell] circular imports on frontend #1408

ghost opened this issue Feb 14, 2024 · 1 comment · May be fixed by #1415
Labels
bug Something isn't working web

Comments

@ghost
Copy link

ghost commented Feb 14, 2024

The tanstack router PR #1338 introduced circular imports. Vite says: [vite] page reload src/routes.tsx (circular imports) but also dpdm:

$  pnpx dpdm src/index.tsx
• Circular Dependencies
  1) src/routes.tsx -> src/screens/auth/index.ts -> src/screens/auth/Login.tsx
  2) src/routes.tsx -> src/screens/filters/index.ts -> src/screens/filters/Details.tsx
  3) src/routes.tsx -> src/screens/filters/index.ts -> src/screens/filters/NotFound.tsx
  4) src/routes.tsx -> src/screens/settings/Logs.tsx
  5) src/routes.tsx -> src/screens/settings/Application.tsx
  6) src/routes.tsx -> src/components/header/index.tsx -> src/components/header/Header.tsx
  7) src/routes.tsx -> src/screens/Releases.tsx -> src/screens/releases/ReleaseTable.tsx
  8) src/routes.tsx -> src/screens/settings/Account.tsx
@ghost ghost added the bug Something isn't working label Feb 14, 2024
@martylukyy
Copy link
Collaborator

Thanks for providing a list of all the circular imports!
Some of the circular imports were there even before the migration to @tanstack/router..
I know about this and if i have enough spare time i will try to fix it to make HMR work again.

@kaiserbh kaiserbh linked a pull request Feb 17, 2024 that will close this issue
@zze0s zze0s added the web label Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working web
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants