Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building on macOS emits a deprecation warning #67

Open
gedw99 opened this issue Jan 9, 2022 · 3 comments
Open

Building on macOS emits a deprecation warning #67

gedw99 opened this issue Jan 9, 2022 · 3 comments
Labels
area/dependencies Affects dependencies area/storage Affects the way configuration is stored priority/3 low This would be nice to have state/needs discussion This can't be worked on yet

Comments

@gedw99
Copy link

gedw99 commented Jan 9, 2022

mac OS version: 11.6.2

on build of cmd i get:


# github.com/keybase/go-keychain
cgo-gcc-prolog:203:11: warning: 'SecTrustedApplicationCreateFromPath' is deprecated: first deprecated in macOS 10.15 - No longer supported [-Wdeprecated-declarations]
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/System/Library/Frameworks/Security.framework/Headers/SecTrustedApplication.h:59:10: note: 'SecTrustedApplicationCreateFromPath' has been explicitly marked deprecated here

Maybe we still need to have this to support old versions of Mac OS ?

@jzelinskie
Copy link
Member

This is an issue with the 99designs/keyring library. Here's the upstream issue: 99designs/keyring#66

@jzelinskie jzelinskie added the priority/3 low This would be nice to have label Jan 9, 2022
@gedw99
Copy link
Author

gedw99 commented Jan 9, 2022

hey @jzelinskie

https://github.com/99designs/keyring/blob/master/keychain.go#L10 uses github.com/keybase/go-keychain

this supports all desktops and uses shell commands:

package main

import (
	"log"

	"github.com/zalando/go-keyring"
)

func main() {
	service := "my-app"
	user := "anon"
	password := "secret"

	// set password
	err := keyring.Set(service, user, password)
	if err != nil {
		log.Fatal(err)
	}

	// get password
	secret, err := keyring.Get(service, user)
	if err != nil {
		log.Fatal(err)
	}

	log.Println(secret)
}

@gedw99
Copy link
Author

gedw99 commented Jan 9, 2022

For github CI, do you use the github secrets engine ?

@jzelinskie jzelinskie added area/dependencies Affects dependencies area/storage Affects the way configuration is stored state/needs discussion This can't be worked on yet labels Jan 12, 2022
@jzelinskie jzelinskie changed the title OSX keychain deprecated Building on macOS emits a deprecation warning Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies Affects dependencies area/storage Affects the way configuration is stored priority/3 low This would be nice to have state/needs discussion This can't be worked on yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants