Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No default OS affinity but can't run on Windows nodes #185

Open
rcmosher opened this issue Apr 27, 2023 · 2 comments
Open

No default OS affinity but can't run on Windows nodes #185

rcmosher opened this issue Apr 27, 2023 · 2 comments
Labels
kind/tech debt Addresses legacy code/decisions priority/3 low This would be nice to have

Comments

@rcmosher
Copy link

We're using the spicedb-operator to deploy to our K8S cluster. Our cluster allows for both Linux and Windows nodes. Occasionally we'll end up with a pod trying to start on a Windows node and failing. We can get around this with a patch, but since Windows nodes are not supported it would make sense to exclude it by default.

The patch in our SpiceDBCluster definition is as follows:

  patches:
  - kind: '*'
    patch:
      metadata:
        labels:
          added: via-patch
      spec:
        affinity:
          nodeAffinity:
            requiredDuringSchedulingIgnoredDuringExecution:
              nodeSelectorTerms:
              - matchExpressions:
                - key: kubernetes.io/os
                  operator: In
                  values:
                  - linux
@ecordell ecordell added kind/tech debt Addresses legacy code/decisions priority/3 low This would be nice to have labels Apr 27, 2023
@rcmosher
Copy link
Author

rcmosher commented Apr 27, 2023

I should add we've seen this patch ignored, probably due to deleting and recreating the SpiceDbCluster. And we've seen the spicedb-operator try to use a Windows node, which I don't think this patch controls. Nor does it seem to affect the spicedb-migration pod

@jzelinskie
Copy link
Member

SpiceDB releases cut Windows binaries -- we should explore how much additional effort it'd just push Windows images.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/tech debt Addresses legacy code/decisions priority/3 low This would be nice to have
Projects
None yet
Development

No branches or pull requests

3 participants