generated extensions do not pass JsHint

[distracteddev]

Planning on fixing this soon, just placing this here to remind myself.

[dotcypress]

Ok. Thanks for your help.

[robertd]

@distracteddev Are you still experiencing this issue?

[distracteddev]

I haven't generated anything in a while but I imagine its still there unless the templates have been updated.

[robertd]

JSHint Report

/*jshint forin:true, noarg:true, noempty:true, eqeqeq:true, bitwise:true, strict:true, undef:true, unused:true, curly:true, browser:true, devel:true, node:true, indent:4, maxerr:50 */
Errors:

Line 3: return {

Missing "use strict" statement.

Line 1: define(['underscore'], function (_) {

'define' is not defined.

Line 1: define(['underscore'], function (_) {

'_' is defined but never used.

Line 5: initialize: function (application) {

'application' is defined but never used.

Other than implementing use strict; ... what else can we really add to the template? Am I missing something?

[fudanchii]

@robertd Did you jshint them manually? As far as I'm concerned, the Gruntfile should be fixed first, it doesn't actually linting those files under extensions and aura_components folder (line 95-96).

The define error shouldn't be there since it's flagged at .jshintrc. All that left to get fixed is adding strict mode and either make use underscorejs to do something, or remove them from the corresponding files.

[robertd]

Yeah... I jshint them manually. I would like someone to take a stab at Gruntfile in what direction it should go as mentioned in #14.

As far for the other templates... yeah... whip up a PR and I'll merge them in.

[fudanchii]

Ok, tried to put some work on that (#18), some review would be nice.

[robertd]

@fudanchii 👍