Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libcontainer dependency was updated and our cargo.toml is only pinned to the branch, not the commit #467

Open
GANitak opened this issue Mar 24, 2023 · 2 comments
Labels
Auraed The Aurae Daemon (gRPC Server)

Comments

@GANitak
Copy link
Contributor

GANitak commented Mar 24, 2023

MAIN branch :

  • cargo.lock has a commit hash cc2a4d0fdd5d7f2c05a218322a0c8bfd0ea22fdf
    -> not on the branch (musl-libcontainer)

Changing the hash to in cargo.toml :
0836dbf2fa358d66e026b321f3d44c636b89091f create a new error :

Checking libcontainer v0.0.4 (https://github.com/krisnova/youki?branch=musl-libcontainer#cc2a4d0f)
error[E0308]: mismatched types
--> /home/ganitak/.cargo/git/checkouts/youki-ecf4771dd4ac50dc/cc2a4d0/crates/libcontainer/src/process/container_intermediate_process.rs:147:17
|
147 | resources,
| ^^^^^^^^^ expected struct oci_spec::runtime::linux::LinuxResources, found struct LinuxResources
|
= note: struct LinuxResources and struct oci_spec::runtime::linux::LinuxResources have similar names, but are actually distinct types
note: struct LinuxResources is defined in crate oci_spec
--> /home/ganitak/.cargo/registry/src/github.com-1ecc6299db9ec823/oci-spec-0.5.8/src/runtime/linux.rs:654:1
|
654 | pub struct LinuxResources {
| ^^^^^^^^^^^^^^^^^^^^^^^^^
note: struct oci_spec::runtime::linux::LinuxResources is defined in crate oci_spec
--> /home/ganitak/.cargo/registry/src/github.com-1ecc6299db9ec823/oci-spec-0.6.0/src/runtime/linux.rs:658:1
|
658 | pub struct LinuxResources {
| ^^^^^^^^^^^^^^^^^^^^^^^^^
= note: perhaps two different versions of crate oci_spec are being used?

For more information about this error, try rustc --explain E0308.
error: could not compile libcontainer due to previous error
make: *** [Makefile:235: auraed-lint] Error 101

I am guessing there is more to change...

On going

@GANitak GANitak added the Auraed The Aurae Daemon (gRPC Server) label Mar 24, 2023
@yihuaf
Copy link
Contributor

yihuaf commented Jun 17, 2023

I can help fixing this.

@yihuaf
Copy link
Contributor

yihuaf commented Jun 20, 2023

I believe this is resolved in #483 now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auraed The Aurae Daemon (gRPC Server)
Projects
None yet
Development

No branches or pull requests

2 participants