Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audacity crash upon installing Nyquist Plugins #6433

Closed
chinakov opened this issue May 13, 2024 · 5 comments · Fixed by #6444
Closed

Audacity crash upon installing Nyquist Plugins #6433

chinakov opened this issue May 13, 2024 · 5 comments · Fixed by #6444
Labels
bug An error, undesired behaviour, or missed functionality P1 Highest level priority (ship blocker / must fix) plugins Bugs with external plugins, such as VSTs, LV2, Vamp and Nyquist. regression Bug is a regression against previous version
Milestone
Audacity 3.6

Comments

@chinakov
Copy link
Contributor

chinakov commented May 13, 2024 •
edited

Bug description

If a User installs a new Nyquist plugin, effect or generator, Audacity will crash upon installing any of them.

Steps to reproduce

  1. Open Audacity
  2. Grab any Nyquist component
  3. Install the component via 'Tools -> Nyquist Plugin Installer'
  4. Press 'Apply'

Expected behavior

The Nyquist plugin is installed without any issues.

Actual behavior

Audacity crashes when installing any Nyquist Plugins.

Audacity Version

current master / alpha / nightly build

Operating system

Windows

Additional context

I've bisected the introduction of this issue back to when 983dc1b got merged. Previous master builds do not exhibit this behaviour.
@chinakov chinakov added bug An error, undesired behaviour, or missed functionality plugins Bugs with external plugins, such as VSTs, LV2, Vamp and Nyquist. P1 Highest level priority (ship blocker / must fix) labels May 13, 2024
@chinakov chinakov added this to the Audacity 3.6 milestone May 13, 2024
@petersampsonaudacity
Copy link

@chinakov - so is this a regression Anton?

@petersampsonaudacity
Copy link

Testing on W11 shows this is a regression on 3.5.1

@petersampsonaudacity petersampsonaudacity added the regression Bug is a regression against previous version label May 13, 2024
@chinakov chinakov mentioned this issue May 14, 2024
Closed
@chinakov
Copy link
Contributor Author

chinakov commented May 15, 2024 •
edited

I've traced the particular commit in wave-refactoring-branch that created this issue: it was the last commit in the branch (0baba5e)

@vsverchinsky vsverchinsky mentioned this issue May 16, 2024
Merged
6 tasks
@chinakov
Copy link
Contributor Author

This is fixed, thank you!

@petersampsonaudacity
Copy link

petersampsonaudacity commented May 17, 2024 •
edited

This is fixed, thank you!

Still fails, with crash, on latest 3.6.0 alpha master: audacity-win-3.6.0-alpha-20240517+15e23de-x64-msvc2022

UPDATE - now works a treat with the latest master alpha 3.6.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug An error, undesired behaviour, or missed functionality P1 Highest level priority (ship blocker / must fix) plugins Bugs with external plugins, such as VSTs, LV2, Vamp and Nyquist. regression Bug is a regression against previous version
Projects
Main board
Status: Done
Milestone
Audacity 3.6
Development

Successfully merging a pull request may close this issue.

Fix null pointer dereference vsverchinsky/audacity
2 participants
@petersampsonaudacity @chinakov