From df907c662c8bb97b0e0ff113d8c84170d4e845a5 Mon Sep 17 00:00:00 2001
From: "Chris J. Karr" <chris@audacious-software.com>
Date: Sun, 28 May 2017 14:43:24 -0500
Subject: [PATCH] Linting refinement for use with host applications

---
 AndroidManifest.xml                                       | 2 +-
 res/values/generators.xml                                 | 6 +++---
 .../passive_data_kit/activities/DiagnosticsActivity.java  | 1 +
 .../passive_data_kit/generators/Generators.java           | 1 +
 .../passive_data_kit/generators/device/Location.java      | 1 +
 .../passive_data_kit/transmitters/Transmitter.java        | 8 ++++++++
 6 files changed, 15 insertions(+), 4 deletions(-)

diff --git a/AndroidManifest.xml b/AndroidManifest.xml
index 2137d36..5bfc46a 100755
--- a/AndroidManifest.xml
+++ b/AndroidManifest.xml
@@ -10,7 +10,7 @@
     <!--suppress DeprecatedClassUsageInspection -->
     <uses-permission android:name="android.permission.GET_TASKS" />
     <uses-permission android:name="android.permission.PACKAGE_USAGE_STATS" tools:ignore="ProtectedPermissions" />
-    <application android:allowBackup="true"
+    <application android:allowBackup="false"
         android:icon="@mipmap/ic_launcher"
         android:label="@string/app_name"
         android:theme="@style/AppTheme"
diff --git a/res/values/generators.xml b/res/values/generators.xml
index 22b30ec..7e1d3c4 100755
--- a/res/values/generators.xml
+++ b/res/values/generators.xml
@@ -1,6 +1,6 @@
 <!--suppress CheckTagEmptyBody -->
-<resources>
-    <string-array name="pdk_available_generators">
+<resources xmlns:tools="http://schemas.android.com/tools">
+    <string-array name="pdk_available_generators" tools:ignore="InconsistentArrays">
         <item>com.audacious_software.passive_data_kit.generators.device.Location</item>
         <item>com.audacious_software.passive_data_kit.generators.device.ScreenState</item>
         <item>com.audacious_software.passive_data_kit.generators.communication.PhoneCalls</item>
@@ -16,7 +16,7 @@
         <item>com.audacious_software.passive_data_kit.generators.diagnostics.SystemStatus</item>
     </string-array>
 
-    <string-array name="pdk_app_generators"></string-array>
+    <string-array name="pdk_app_generators" tools:ignore="InconsistentArrays"></string-array>
 
     <string name="generator_value_not_applicable">n/a</string>
 
diff --git a/src/com/audacious_software/passive_data_kit/activities/DiagnosticsActivity.java b/src/com/audacious_software/passive_data_kit/activities/DiagnosticsActivity.java
index c7f8dec..2f71bbd 100755
--- a/src/com/audacious_software/passive_data_kit/activities/DiagnosticsActivity.java
+++ b/src/com/audacious_software/passive_data_kit/activities/DiagnosticsActivity.java
@@ -21,6 +21,7 @@
 import java.util.ArrayList;
 
 public class DiagnosticsActivity extends AppCompatActivity {
+    @SuppressWarnings("SameParameterValue")
     @SuppressLint("AlwaysShowAction")
     public static void setUpDiagnositicsItem(Activity activity, Menu menu, boolean showAction) {
         final ArrayList<DiagnosticAction> actions = PassiveDataKit.diagnostics(activity);
diff --git a/src/com/audacious_software/passive_data_kit/generators/Generators.java b/src/com/audacious_software/passive_data_kit/generators/Generators.java
index 2197d85..b2a31b1 100755
--- a/src/com/audacious_software/passive_data_kit/generators/Generators.java
+++ b/src/com/audacious_software/passive_data_kit/generators/Generators.java
@@ -227,6 +227,7 @@ public List<Class<? extends Generator>> activeGenerators() {
         return active;
     }
 
+    @SuppressWarnings("SameParameterValue")
     public void notifyGeneratorUpdated(String identifier, long timestamp, Bundle bundle) {
         for (GeneratorUpdatedListener listener : this.mGeneratorUpdatedListeners) {
             listener.onGeneratorUpdated(identifier, timestamp, bundle);
diff --git a/src/com/audacious_software/passive_data_kit/generators/device/Location.java b/src/com/audacious_software/passive_data_kit/generators/device/Location.java
index 6661138..58b655a 100755
--- a/src/com/audacious_software/passive_data_kit/generators/device/Location.java
+++ b/src/com/audacious_software/passive_data_kit/generators/device/Location.java
@@ -1005,6 +1005,7 @@ public android.location.Location getLastKnownLocation() {
         return last;
     }
 
+    @SuppressWarnings("SameParameterValue")
     public void setUpdateInterval(long interval) {
         this.mUpdateInterval = interval;
 
diff --git a/src/com/audacious_software/passive_data_kit/transmitters/Transmitter.java b/src/com/audacious_software/passive_data_kit/transmitters/Transmitter.java
index 40d7c87..ecbb2e3 100755
--- a/src/com/audacious_software/passive_data_kit/transmitters/Transmitter.java
+++ b/src/com/audacious_software/passive_data_kit/transmitters/Transmitter.java
@@ -4,9 +4,17 @@
 
 import java.util.HashMap;
 
+@SuppressWarnings("WeakerAccess")
 public abstract class Transmitter {
+    @SuppressWarnings("unused")
     public abstract void initialize(Context context, HashMap<String, String> options);
+
+    @SuppressWarnings({"SameParameterValue", "unused"})
     public abstract void transmit(boolean force);
+
+    @SuppressWarnings("unused")
     public abstract long pendingSize();
+
+    @SuppressWarnings("unused")
     public abstract long transmittedSize();
 }