Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

html_static_path settings are not preserved #157

Open
hroemer opened this issue Dec 15, 2023 · 2 comments
Open

html_static_path settings are not preserved #157

hroemer opened this issue Dec 15, 2023 · 2 comments
Assignees
Labels
high:bug Something isn't working
Milestone

Comments

@hroemer
Copy link

hroemer commented Dec 15, 2023

Configuration settings for html_static_path are overwritten in builders.py:

        # Hand over builder configs to html builder.
        setattr(self.config, "html_static_path", self.config.revealjs_static_path)

Thus any static files defined either in conf.py or by other extensions are ignored and essentially do not get copied to the output.

Could you please change it to something conceptually like this, preserving existing values:

        # Hand over builder configs to html builder.
        hsp = getattr(self.config, "html_static_path")
        hsp = hsp + self.config.revealjs_static_path if hsp else self.config.revealjs_static_path
        setattr(self.config, "html_static_path", hsp)

Regards,

@attakei
Copy link
Owner

attakei commented Jan 13, 2024

Thank you for feedback.

This was implemented for rightly work on old version.
It may be able to delete in current version, but it is not certain by not remember why implement it.

I will check that it until v3.x releases (probably delete it).

@attakei attakei self-assigned this Jan 13, 2024
@attakei attakei added the v3.0 label Jan 13, 2024
@attakei attakei added this to the v3.0 milestone Jan 13, 2024
attakei added a commit that referenced this issue Feb 4, 2024
- Append function to copy revealjs assets.
- Refs: #157
@attakei attakei added the high:bug Something isn't working label Mar 3, 2024
@attakei
Copy link
Owner

attakei commented Mar 3, 2024

I have regarded it as bug from old implementation, and fix it by v3.0.0.

@attakei attakei removed the v3.0 label May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
high:bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants