Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary warning messages #1335

Open
celalsahin opened this issue Feb 12, 2024 · 3 comments
Open

Unnecessary warning messages #1335

celalsahin opened this issue Feb 12, 2024 · 3 comments

Comments

@celalsahin
Copy link

Hello!

Warning level logging is way too chatty even in %100 success cases. There are multiple examples where the method attempts what it exactly needs to do - but library still prints a warning log. Some examples are:

https://github.com/atlassian-api/atlassian-python-api/blob/master/atlassian/jira.py#L1344
https://github.com/atlassian-api/atlassian-python-api/blob/master/atlassian/jira.py#L1394
https://github.com/atlassian-api/atlassian-python-api/blob/master/atlassian/jira.py#L1400
...

So from my POV if a method does an update of an issue, it is not a warning that it is updating an issue - am I somewhat wrong?

Thanks!
Celal

@Gerolf-Reinwardt
Copy link

I see it the same way, this should never be more then an info, maybe just trace/debug. Library users, who call the API multiple times (may by an automatism, that updates 500 issues), get flooded with warnings, which are none. So finding the real problems gets hard.

@gkowalc
Copy link
Contributor

gkowalc commented Feb 16, 2024

It some cases these warnings make sense for example in confluence.py:
@deprecated(version="2.4.2", reason="Use get_all_restrictions_for_content()") def get_all_restictions_for_content(self, content_id): """Let's use the get_all_restrictions_for_content()""" log.warning("Please, be informed that is deprecated as typo naming")
but on many others it can indeed create a bit of noise. I would opt for lowering logging level for these informational message to 'info' logging level so that people can easily filter them out and only log warnings/errors levels.

@Spacetown
Copy link
Contributor

This warning doesn't make sense sind python warns already about the deprecation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants