Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deal with overlapping timezones #2

Closed
ateucher opened this issue May 2, 2019 · 1 comment · Fixed by #5
Closed

Deal with overlapping timezones #2

ateucher opened this issue May 2, 2019 · 1 comment · Fixed by #5

Comments

@ateucher
Copy link
Owner

ateucher commented May 2, 2019

There are some regions in the world where a single point can land in
two different overlapping timezones. The "accurate" method includes these,
however the method used in the "fast" does not include overlapping timezones
(at least for now).

The implication is that the accurate method can return a result longer than the input, and since the return value is a character vector, there is no way to align the results to the input. Possibly make it a named vector with names like c(1, 2, 3.1, 3.2)...

@ateucher
Copy link
Owner Author

ateucher commented May 2, 2019

Could return a list where some elements are a single timezone, and where they are duplicated the list element is a length-2 vector of timezones. Or alternatively it always returns a data frame instead of a character vector, and throw a warning if the returned data frame is longer than the input

ateucher added a commit that referenced this issue Jul 12, 2019
(concatenate into one string with a ; separator). Closes #2
@ateucher ateucher mentioned this issue Jul 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant