Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update of test workflow to use latest node #543

Closed
derberg opened this issue May 24, 2023 · 2 comments
Closed

Update of test workflow to use latest node #543

derberg opened this issue May 24, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@derberg
Copy link
Member

derberg commented May 24, 2023

Reason/Context

This workflow uses node action v1 and node 13

Because of https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/ it should be updated to use node 14 at least, but probably best is 18

12 is deprecated soon and 13 is not even LTS release

Description

replace

      - name: Setup Node.js
        uses: actions/setup-node@v1
        with:
          node-version: 13

with

      - name: Setup Node.js
        uses: actions/setup-node@v3
        with:
          node-version: 18

also change actions/checkout@v2 to actions/checkout@v3 as v2 runs on node12

@jonaslagoni please confirm node version and you can probably mark it as good first issue using ci-cd keyword

@derberg derberg added the enhancement New feature or request label May 24, 2023
@github-actions
Copy link

Welcome to AsyncAPI. Thanks a lot for reporting your first issue. Please check out our contributors guide and the instructions about a basic recommended setup useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@jonaslagoni
Copy link
Sponsor Member

Closing in favor of #544

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants