Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement more dotnet best practises #200

Open
thompson-tomo opened this issue Apr 21, 2024 · 2 comments · May be fixed by #201
Open

Implement more dotnet best practises #200

thompson-tomo opened this issue Apr 21, 2024 · 2 comments · May be fixed by #201

Comments

@thompson-tomo
Copy link

thompson-tomo commented Apr 21, 2024 •
edited

Why do we need this improvement?

Move to dotnet best practises

How will this change help?

Simplify maintaince

How could it be implemented/designed?

  • Replace AssemblyInfo.cs with properties in *.csproj
  • Move to central package management
  • Move key properties into a *.props file

🚧 Breaking changes

No

Additional info

https://www.meziantou.net/declaring-internalsvisibleto-in-the-csproj.htm

Editor Config has been split off to #202
@thompson-tomo thompson-tomo changed the title Migrate AssemblyInfo.cs to be provided by *.csproj Implement more dotnet best practises Apr 21, 2024
@thompson-tomo thompson-tomo linked a pull request Apr 21, 2024 that will close this issue
Open
@yurvon-screamo
Copy link
Collaborator

Hi, editorconfig it's cool. However, it should be created based on our code style (and there is none). I suggest you start working on its description and then move on to the editor config itself. Let's start describing the codestyle together (for example, in CONTRIBUTING.md ), we will accept it and then create an editorconfig.

@thompson-tomo
Copy link
Author

@yurvon-screamo sure, i have split the editorconfig off in to #202 so that can have more detailed discussion and the changes here can pass through sooner.

@thompson-tomo thompson-tomo mentioned this issue Apr 25, 2024
Draft
@thompson-tomo thompson-tomo mentioned this issue May 21, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#200 implement dotnet best practises thompson-tomo/saunter
2 participants
@thompson-tomo @yurvon-screamo