Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need for urgent changes in GitHub Actions automation #289

Open
derberg opened this issue May 30, 2023 · 4 comments · May be fixed by #338
Open

Need for urgent changes in GitHub Actions automation #289

derberg opened this issue May 30, 2023 · 4 comments · May be fixed by #338
Labels
area/ci-cd Specify what technical area given issue relates to. Its goal is to ease filtering good first issues. Hacktoberfest Label issues as available for participants of https://hacktoberfest.digitalocean.com stale

Comments

@derberg
Copy link
Member

derberg commented May 30, 2023

This issue defines a list of tasks that need to be performed in this repo to make sure it's ci/cd automation works long term without any issues.

It is up to maintainers to decide if it must be addressed in one or multiple PRs.

Below are 3 different sections describing 3 different important ci/cd changes.

IMPORTANT-START
For GitHub workflows that contain This workflow is centrally managed in https://github.com/asyncapi/.github/ you do not have to perform any work. These workflows were already updated through the update in .github. The only exception is the workflows related to nodejs release. More details in Upgrade Release pipeline - in case of nodejs projects section
IMPORTANT-END

Deprecation of way data is shared between steps

Every single GitHub Action workflow that has echo "::set-output name={name}::{value}" need to be updated to follow echo "{name}={value}" >> $GITHUB_OUTPUT

We do not yet know when set-output will stop working. Previous disable date was 31.05 but now then say community needs more time.

For more details read official article from GitHub

Deprecation of node12

2nd bullet point is still relevant for you even if your projects in not nodejs project

  • Every single workflow that uses setup-node action needs an update to follow v3 version of this action, and make sure minimum node 14 is used
  • Now this part is more complex. Problem with node12 is that node-based GitHub Actions were using it in majority as a runtime environment. Look for example at this action.yaml file for setup-node action v2. So the job that you have to do is go through all the workflows, and verify every single action that you use, make sure you are using the latest version that is not based on node12. I already did review a lot of actions as part of this PR so maybe you will find some actions there and can copy from me. For example action/checkout needs to be updated to v3.

Node12 end of support in action is probably September 27th.

For more details read official article from GitHub

Upgrade Release pipeline - in case of nodejs projects

ignore this section if your project is not nodejs project

You have 2 options. You can:

A. choose to switch to new release pipeline using instruction from asyncapi/.github#205

B. stay with old release pipeline, and manually update GitHub workflows and actions used in it, you can inspire a lot from this PR asyncapi/.github#226

I definitely recommend going with A

Workflows related to release:

  • .github/workflows/if-nodejs-release.yml
  • .github/workflows/if-nodejs-version-bump.yml
  • .github/workflows/bump.yml
@derberg derberg added the area/ci-cd Specify what technical area given issue relates to. Its goal is to ease filtering good first issues. label May 30, 2023
@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@github-actions github-actions bot added the stale label Sep 28, 2023
@derberg
Copy link
Member Author

derberg commented Oct 3, 2023

no other workflows here than from .github repo - can be closed

@derberg derberg closed this as completed Oct 3, 2023
@derberg derberg reopened this Oct 3, 2023
@derberg
Copy link
Member Author

derberg commented Oct 3, 2023

Scope of this issue

Cleanup package.json from the following:

  • remove script "release": "semantic-release"
  • remove the following devDependencies and then run npm install 
    @semantic-release/commit-analyzer
@semantic-release/github
@semantic-release/npm
@semantic-release/release-notes-generator
conventional-changelog-conventionalcommits
semantic-release
  • remove release property (object)

in PR please tag @derberg as I need to review + merge + do some global config changes

@derberg derberg added the Hacktoberfest Label issues as available for participants of https://hacktoberfest.digitalocean.com label Oct 3, 2023
@github-actions github-actions bot removed the stale label Oct 4, 2023
@akkshitgupta akkshitgupta linked a pull request Jan 14, 2024 that will close this issue
Open
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 1, 2024

This issue has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@github-actions github-actions bot added the stale label Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/ci-cd Specify what technical area given issue relates to. Its goal is to ease filtering good first issues. Hacktoberfest Label issues as available for participants of https://hacktoberfest.digitalocean.com stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: update package.json and GitHub Workflows akkshitgupta/nodejs-ws-template
1 participant
@derberg