Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support decimal min and max #326

Open
Tenischev opened this issue Sep 4, 2023 · 4 comments · May be fixed by #380
Open

Support decimal min and max #326

Tenischev opened this issue Sep 4, 2023 · 4 comments · May be fixed by #380
Labels
area/java Specify what technical area given issue relates to. Its goal is to ease filtering good first issues. bug Something isn't working good first issue Good for newcomers

Comments

@Tenischev
Copy link
Member

Describe the bug

I defined a field as type number and format double with minimum as 0.01. The asyncapi cli generator generated with java springboot template defined the field correctly as Double but the jakarta validation @min accepts only long. It seems like only @DecimalMin can support decimal types but it requires a string type.

Similar discussion - https://stackoverflow.com/questions/7422803/why-do-bean-validation-min-max-constraints-not-support-the-double-type

Bug reported by Sajeesh Kumar in Slack

Expected behavior

DecimalMin \ DecimalMax is used for Double validation
@Tenischev Tenischev added the bug Something isn't working label Sep 4, 2023
@codingmickey
Copy link

Hi @Tenischev I would like to help resolve this!

@Tenischev
Copy link
Member Author

Hi @codingmickey! Glad to hear =)
Please go ahead and make PR. From my brief look update is required only in template/src/main/java/com/asyncapi/model/$$objectSchema$$.java file where @Min and @Max annotations are set.

@Tenischev Tenischev added the good first issue Good for newcomers label Sep 5, 2023
@Tenischev
Copy link
Member Author

Hey @codingmickey any progress with it?
Do you need a help?

@Tenischev Tenischev added the area/java Specify what technical area given issue relates to. Its goal is to ease filtering good first issues. label Dec 19, 2023
@rakeshkodathala rakeshkodathala linked a pull request Feb 22, 2024 that will close this issue
Open
@rakeshkodathala
Copy link

Hi, @Tenischev, Could you please check my PR and let me know if any changes are required?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/java Specify what technical area given issue relates to. Its goal is to ease filtering good first issues. bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: changes made to the objectSchema rakeshkodathala/java-spring-template
3 participants
@Tenischev @codingmickey @rakeshkodathala