Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add AMQP 1.0 support and adapter for Glee #462

Closed

Conversation

kaushik-rishi
Copy link
Contributor

Description

Related issue(s)

@kaushik-rishi
Copy link
Contributor Author

cc: @KhudaDad414
Just made a draft PR to show progress.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 5245215008

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 60.53%

Totals Coverage Status
Change from base Build 5142697538: 0.0%
Covered Lines: 324
Relevant Lines: 454

💛 - Coveralls

@sonarcloud
Copy link

sonarcloud bot commented Jun 12, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@kaushik-rishi kaushik-rishi changed the title feat: add amqp 1.0 support feat: add AMQP 1.0 support and adapter for Glee Jun 12, 2023
@kaushik-rishi
Copy link
Contributor Author

It's about adding a new adapter that supports AMQP 1.0 right?
cc: @KhudaDad414 @fmvilas

@kaushik-rishi
Copy link
Contributor Author

I've setup the local AMQP 1.0 broker and fiddling with rhea package to interact with the amqp1.0 local broker

I'll further try to understand the events being emitted and how to normalize them to adapt to glee by studying other existing adapters.

@KhudaDad414
Copy link
Member

It's about adding a new adapter that supports AMQP 1.0 right? cc: @KhudaDad414 @fmvilas

yes. exactly. in theory it is just a matter of adding a new adapter.

@KhudaDad414
Copy link
Member

@kaushik-rishi something that I can help with?

@kaushik-rishi
Copy link
Contributor Author

Hey @KhudaDad414.
Was busy for a bit with making proposal and submitting (since the deadline was extended for the project I was submitting to). I'm back on it. Will let you know if I need any. Thanks for understanding. 😄

@KhudaDad414
Copy link
Member

@kaushik-rishi are you still working on this?

@KhudaDad414
Copy link
Member

@kaushik-rishi pingy pongy 😄

@kaushik-rishi
Copy link
Contributor Author

@KhudaDad414 yes, working on this.

@KhudaDad414
Copy link
Member

Hey @kaushik-rishi do you need some help with this?

@KhudaDad414
Copy link
Member

hey @kaushik-rishi please reopen this PR when it is ready for review. 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants