Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistant expectation for location of header data (vs. other metadata) #1102

Open
cshanahan1 opened this issue Nov 15, 2023 · 2 comments
Open

Comments

@cshanahan1
Copy link
Contributor

The location of header keywords is inconsistent - wcs1d_fits writer will update the output header with anything in the spectrum.meta dictionary. Tabular fits expects header-specific keys to be in meta.header, as a fits.Header object (and will ignore it if its a dictionary). I'm not sure what the other readers/writers do, but it is inconsistent at least in these. Because there can be other information in meta that might not belong in the fits file header, meta.header is preferable (either as dict or Header?)

(Issue made after discussion with @kelle @havok2063, @tepickering)

@dhomeier
Copy link
Contributor

See previous discussion in #617 – roughly speaking I think half of the other specialised loaders handle it one way, the rest the other, and at the time the discussion never wrapped up to a conclusion.

@kelle
Copy link
Member

kelle commented Nov 16, 2023

Also relevant to #1101 , which is about documentation. I think we should at least be honest about the situation in the documentation and give people a suggestion for what to do moving forward with new reader/writers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants