Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Round-trip WCS through ASDF #1046

Open
rosteen opened this issue Mar 27, 2023 · 2 comments
Open

Round-trip WCS through ASDF #1046

rosteen opened this issue Mar 27, 2023 · 2 comments
Labels
effort-high feature io

Comments

@rosteen
Copy link
Contributor

rosteen commented Mar 27, 2023 •
edited by pllim

In reviewing #1042 I noticed that the ASDF converters have never round-tripped the wcs attributes. We should update the converters to do so.

Blocked by:

馃惐
@rosteen rosteen added the io label Mar 27, 2023
@rosteen rosteen added this to the v1.x milestone Mar 27, 2023
@pllim
Copy link
Member

pllim commented Mar 29, 2023

For the WCS, I am not sure if it is possible given that spacetelescope/gwcs#99 is still open, unless @braingram or @WilliamJamieson have ideas.

@pllim
Copy link
Member

pllim commented Mar 30, 2023 •
edited

I am splitting off the mask one to a new issue (#1052). WCS is unlikely to be resolved unless something drastic happens to the conversion between FITS WCS (not supported by ASDF) and GWCS (supported by ASDF).

@pllim pllim changed the title Round-trip mask and WCS through ASDF Round-trip WCS through ASDF Mar 30, 2023
@pllim pllim removed this from the v1.x milestone Mar 30, 2023
@pllim pllim mentioned this issue Mar 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort-high feature io
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pllim @rosteen