Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MIVOT: automatically generate SkyCoord instances #532

Open
lmichel opened this issue Mar 18, 2024 · 0 comments
Open

MIVOT: automatically generate SkyCoord instances #532

lmichel opened this issue Mar 18, 2024 · 0 comments

Comments

@lmichel
Copy link
Contributor

lmichel commented Mar 18, 2024

As PR #497 is very large, we have decided not to overload it with advanced features. The reason for this is both to limit the review task, and to ensure that the deep layers are valid before moving on.

This issue proposes a feature that could be implemented once #497 is merged.
We could add a module (in the features package) able to automatically generate Astropy@SkyCoord instances from the MIVOT annotations.
This would be a 2 step process:

  • Check that the mapped models have the data needed to create Astropy@SkyCoord instances.
  • Interpreting the model elements as SkyCoord parameters.

The code below illustrates how this new module could be used:

scs_srv = SCSService(vizier_url)
m_viewer = MivotViewer(
        scs_srv.search(
            pos=SkyCoord(ra=52.26708 * easting, dec=59.94027 * easting, frame='icrs'),
            radius=0.05
        )
    )
while m_viewer.next():
    sky_coord = m_viewer.sky_coord()

This approach is meant to be extended to other quantities such as Timeor Photometric data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants