Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency with XML parser #498

Open
somilia opened this issue Nov 20, 2023 · 1 comment
Open

Dependency with XML parser #498

somilia opened this issue Nov 20, 2023 · 1 comment
Labels

Comments

@somilia
Copy link
Contributor

somilia commented Nov 20, 2023

The code implementing the MIVOT feature (PR #497) uses lxml.etree. The data model handling requires to run XML operations: parsing and XPATH queries.

However, lxml is not a part of the PyVO dependencies, and is considered insecure as well as the xml native package (xml documentation), the reason why we have been resilient in using them.

The two possibilities are:

  • use defusedxml which will also add a new dependency.
  • add the fragment needed of defusedxml in PyVO (defusedxml is on Python Software Foundation License)

What would you recommend?

@bsipocz
Copy link
Member

bsipocz commented Nov 20, 2023

Either of them ends up as a dependency they will need to be an optional dependency, e.g imports needs to be done as part of conditionals, test should be skipped when the dependency is missing, etc.
For examples see the case e.g. regions in astroquery.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants