Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for service redirects #401

Open
andamian opened this issue Jan 16, 2023 · 3 comments
Open

Support for service redirects #401

andamian opened this issue Jan 16, 2023 · 3 comments

Comments

@andamian
Copy link
Contributor

Your opinion please.

This is a request from ALMA but it might apply to other services too. Their top site almascience.org/tap automatically redirects to one of the mirror sites. They would like to see the direct searches to the top URL work which currently is not possible because POST redirects are no supported.

The way we solved this problem in astroquery.alma was to do a GET on the capabilities of the top URL and use the resulted URL for the subsequent searches/actions.

Do people think it would be a good idea to add something similar to the service constructors in PyVO? Is it worth the extra overhead of the GET call for this enhancement? I'll do the implementation if the feedback is positive.

@msdemlei
Copy link
Contributor

msdemlei commented Jan 17, 2023 via email

@bsipocz
Copy link
Member

bsipocz commented Jan 24, 2023

Would this #96 be the same feature request?

@andamian
Copy link
Contributor Author

This feature just resolves the service URL - if that mirror returns an error it's game over. #96 wants to make the client more resilient by providing it with alternatives. So they are not quite the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants