Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SkyCoord Constructs frames with distance=1*u.one rather than UnitSphericalRepresentation #7247

Open
Cadair opened this issue Feb 28, 2018 · 3 comments
Open

SkyCoord Constructs frames with distance=1*u.one rather than UnitSphericalRepresentation #7247

Cadair opened this issue Feb 28, 2018 · 3 comments
Labels
coordinates

Comments

@Cadair
Copy link
Member

Cadair commented Feb 28, 2018

doing:

SkyCoord(UnitSphericalRepresentation(1*u.deg, 1*u.deg))

passes a distance=1*u.one to the frame constructor, where as it should not pass distance at all to the frame so it constructs UnitSphericalRepresentation.

This causes a lot of problems in sunpy since this commit.
Cadair added a commit to Cadair/sunpy that referenced this issue Feb 28, 2018
@Cadair
Do a *horrific* work around for NorthOffsetFrame
07a4713 
We really need to fix this bug in SkyCoord see astropy/astropy#7247
@Cadair Cadair mentioned this issue Feb 28, 2018
Merged
@pllim
Copy link
Member

pllim commented Feb 28, 2018

Wait a minute, you wrote that commit... 😉

@Cadair
Copy link
Member Author

Cadair commented Feb 28, 2018

sssshhhhhh :p

@Cadair
Copy link
Member Author

Cadair commented May 2, 2018

An alternative discussed with @adrn at pyastro18 is to change what "unit" means so that SunPy could default to RSun rather than 1*u.one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
coordinates
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Cadair @pllim