Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for dbt-clickhouse adapter #95

Closed
chrishronek opened this issue Jan 24, 2023 · 10 comments · May be fixed by #353
Closed

Add support for dbt-clickhouse adapter #95

chrishronek opened this issue Jan 24, 2023 · 10 comments · May be fixed by #353
Labels
enhancement New feature or request

Comments

@chrishronek
Copy link
Contributor

chrishronek commented Jan 24, 2023

Requested via LinkedIn comment.

  • See dbt docs here
  • See clickhouse home page here
@chrishronek chrishronek added the enhancement New feature or request label Jan 24, 2023
@infl18
Copy link

infl18 commented Mar 31, 2023

Hi, is anyone solving this problem?

@CorsettiS
Copy link
Contributor

This is a very desirable feature actually

@vargacypher
Copy link

We'd love to have support to it

@vargacypher
Copy link

vargacypher commented May 19, 2023

Hi @pohek321 could u help me ? Wich parts of the project i need to look/change to solve this issue ?
I know providers and profiles are the main ones to look at

I am willing to submit a PR!

@jlaneve
Copy link
Collaborator

jlaneve commented May 19, 2023

Hi @pohek321 could u help me ? Wich parts of the project i need to look/change to solve this issue ?

I know providers and profiles are the main ones to look at

I am willing to submit a PR!

Hey @vargacypher - I have a PR open that should simplify the process of adding new profiles quite a bit. I'd recommend waiting until it's merged to contribute a new profile! In the meantime, give the PR a look and let me know what you think of the profile/connection definitions.

#271

@roadan
Copy link

roadan commented Jun 26, 2023

@jlaneve I actually have an initial working version of this using your refactored code which I'd love to PR, however, as far as I can see there is no clickhouse connection so my local version is using the generic connection which I think is not a great solution. Any thoughts on how it's best to progress with this?

@CorsettiS
Copy link
Contributor

@roadan do you mind creating a PR so I may be able to check it out? This is also a PR that interests me quite a lot. And about the connection type, there is no clickhouse connection for airflow, therefore using a generic connection type is how clickhouse users have been doing so far, which makes your approach totally correct ✅

@roadan
Copy link

roadan commented Jun 26, 2023

@CorsettiS will do, I just want to add some tests before I do that. The PR should be ready tomorrow.
My concern with the current PR is that the required fields are few so essentially my connector will be able to claim most generic connections. Maybe I can add an extra just for can_claim_connection to match on?

@CorsettiS
Copy link
Contributor

@roadan sounds feasible IMO

Copy link

dosubot bot commented Nov 9, 2023

Hi, @chrishronek. I'm Dosu, and I'm helping the Cosmos team manage their backlog. I wanted to let you know that we are marking this issue as stale.

From what I understand, this issue is a request to add support for the dbt-clickhouse adapter. There has been some discussion in the comments, with roadan mentioning that they have an initial working version using refactored code. CorsettiS has requested roadan to create a pull request (PR) so they can review it. Roadan has mentioned that they will add tests before creating the PR. Additionally, there is a suggestion from CorsettiS to add an extra field for can_claim_connection to address a concern about the current PR claiming most generic connections.

Before we close this issue, we wanted to check with you if it is still relevant to the latest version of the Cosmos repository. If it is, please let the Cosmos team know by commenting on the issue. Otherwise, feel free to close the issue yourself or it will be automatically closed in 7 days.

Thank you for your understanding and contributions to the Cosmos repository. Let us know if you have any further questions or concerns.

@dosubot dosubot bot added the stale Issue has not had recent activity or appears to be solved. Stale issues will be automatically closed label Nov 9, 2023
@dosubot dosubot bot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 16, 2023
@dosubot dosubot bot removed the stale Issue has not had recent activity or appears to be solved. Stale issues will be automatically closed label Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants