-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for dbt-clickhouse adapter #95
Comments
Hi, is anyone solving this problem? |
This is a very desirable feature actually |
We'd love to have support to it |
Hi @pohek321 could u help me ? Wich parts of the project i need to look/change to solve this issue ? I am willing to submit a PR! |
Hey @vargacypher - I have a PR open that should simplify the process of adding new profiles quite a bit. I'd recommend waiting until it's merged to contribute a new profile! In the meantime, give the PR a look and let me know what you think of the profile/connection definitions. |
@jlaneve I actually have an initial working version of this using your refactored code which I'd love to PR, however, as far as I can see there is no clickhouse connection so my local version is using the generic connection which I think is not a great solution. Any thoughts on how it's best to progress with this? |
@roadan do you mind creating a PR so I may be able to check it out? This is also a PR that interests me quite a lot. And about the connection type, there is no clickhouse connection for airflow, therefore using a generic connection type is how clickhouse users have been doing so far, which makes your approach totally correct ✅ |
@CorsettiS will do, I just want to add some tests before I do that. The PR should be ready tomorrow. |
@roadan sounds feasible IMO |
Hi, @chrishronek. I'm Dosu, and I'm helping the Cosmos team manage their backlog. I wanted to let you know that we are marking this issue as stale. From what I understand, this issue is a request to add support for the dbt-clickhouse adapter. There has been some discussion in the comments, with roadan mentioning that they have an initial working version using refactored code. CorsettiS has requested roadan to create a pull request (PR) so they can review it. Roadan has mentioned that they will add tests before creating the PR. Additionally, there is a suggestion from CorsettiS to add an extra field for Before we close this issue, we wanted to check with you if it is still relevant to the latest version of the Cosmos repository. If it is, please let the Cosmos team know by commenting on the issue. Otherwise, feel free to close the issue yourself or it will be automatically closed in 7 days. Thank you for your understanding and contributions to the Cosmos repository. Let us know if you have any further questions or concerns. |
Requested via LinkedIn comment.
The text was updated successfully, but these errors were encountered: