Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNN cartoon issues due to M51 picture #42

Open
bsipocz opened this issue Feb 20, 2019 · 0 comments
Open

CNN cartoon issues due to M51 picture #42

bsipocz opened this issue Feb 20, 2019 · 0 comments
Labels

Comments

@bsipocz
Copy link
Member

bsipocz commented Feb 20, 2019

The M51 picture for the CNN cartoon brings up two low priority issues, one needs documentation only, the other a solution:

  • the jpeg file requires Pillow as a dependency. Maybe the best solution is to convert is to png (the only issue is to make sure the result image is the same as what went into the book).

  • using the current test and pdf generating mechanism (relying on extracting the code out to a temporary "somefile.py") is not working with the current solution for the file path of the image. Running the script directly works, so users shouldn't be affected by is.
    Copying a workaround from the astroML pickle_results mechanism is probably the easiest solution here.

@bsipocz bsipocz added the bug label Feb 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant