Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Code playground #271

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from
Draft

feat: Code playground #271

wants to merge 11 commits into from

Conversation

fazzaamiarso
Copy link
Member

Fixes #263

Description of changes:

  • new playground apps with sveltekit

Tag a reviewer: @ayoayco

Tasks:

  • I have ran the build command to make sure apps are working: npm run build
  • I have ran the tests to make sure nothing is broken: npm run test
  • I have ran the linter to make sure code is clean: npm run lint
  • I have reviewed my own code to remove changes that are not needed

currently deployed here: https://benevolent-taffy-049eb6.netlify.app/

@changeset-bot
Copy link

changeset-bot bot commented Mar 22, 2023

⚠️ No Changeset found

Latest commit: 813da9f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Mar 22, 2023 •
edited

✅ Deploy Preview for astro-reactive canceled.

Name Link
🔨 Latest commit 813da9f
🔍 Latest deploy log https://app.netlify.com/sites/astro-reactive/deploys/641b80f17601dc00087bdd50

@netlify
Copy link

netlify bot commented Mar 22, 2023 •
edited

✅ Deploy Preview for astro-reactive-docs canceled.

Name Link
🔨 Latest commit 813da9f
🔍 Latest deploy log https://app.netlify.com/sites/astro-reactive-docs/deploys/641b80f14cc37d00082f59e4

@fazzaamiarso
Copy link
Member Author

fazzaamiarso commented Mar 22, 2023 •
edited

@ayoayco here's a minimal MVP , I guess? I'm sorry it's still very messy on all aspects, especially UI. I'm also learning Svelte on the fly 😅.

You can try it, but if the iframe unable to load, please check out https://webcontainers.io/guides/browser-config

do we have a particular theme or design system for the UI?

@ayoayco
Copy link
Member

ayoayco commented Mar 24, 2023

Let's get this in and iterate! @fazzaamiarso :) can you check why pipelines fail?

@fazzaamiarso
Copy link
Member Author

@ayoayco Oops, I believe its because of svelte-kit check being strict about types. Already fixed, but not pushed yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create new playground app
2 participants
@fazzaamiarso @ayoayco