Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The device registration limit prevents re-registration of already existing devices #933

Open
davidebriani opened this issue May 2, 2024 · 0 comments · May be fixed by #940
Open

The device registration limit prevents re-registration of already existing devices #933

davidebriani opened this issue May 2, 2024 · 0 comments · May be fixed by #940
Labels
app:pairing_api This issue or pull request is about astarte_pairing_api application user experience This issue is about user experience
Milestone
v1.2

Comments

@davidebriani
Copy link
Collaborator

The device registration limit set for an Astarte realm is meant to prevent device registration when the limit is reached.

The main purpose is to restrict the ability of realm users to create new devices that would allocate more resources.

However, when the limit is reached Astarte also currently forbids re-registering existing devices.
This operation could arguably be allowed since it is useful for generating a new credential secret for the device when the previous one is lost or compromised.
@davidebriani davidebriani added app:housekeeping This issue or pull request is about astarte_housekeeping application app:pairing_api This issue or pull request is about astarte_pairing_api application and removed app:housekeeping This issue or pull request is about astarte_housekeeping application labels May 2, 2024
Annopaolo added a commit to Annopaolo/astarte that referenced this issue May 8, 2024
@Annopaolo
Pairing: allow re-registering devices even if limit is reached
b369db6 
The device registration limit set for an Astarte realm
is meant to prevent registration of new devices when the
limit is reached. However, it blocked re-registration of
already existing devices.
Allow to re-register existing devices without checking
if registration limit has been reached.
See [astarte-platform#933](astarte-platform#933).

Signed-off-by: Arnaldo Cesco <arnaldo.cesco@secomind.com>
@Annopaolo Annopaolo added the user experience This issue is about user experience label May 8, 2024
@Annopaolo Annopaolo added this to the v1.2 milestone May 8, 2024
@Annopaolo Annopaolo linked a pull request May 8, 2024 that will close this issue
Open
Annopaolo added a commit to Annopaolo/astarte that referenced this issue May 14, 2024
@Annopaolo
Pairing: allow re-registering devices even if limit is reached
394adc5 
The device registration limit set for an Astarte realm
is meant to prevent registration of new devices when the
limit is reached. However, it blocked re-registration of
already existing devices.
Allow to re-register existing devices without checking
if registration limit has been reached.
See [astarte-platform#933](astarte-platform#933).

Signed-off-by: Arnaldo Cesco <arnaldo.cesco@secomind.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
app:pairing_api This issue or pull request is about astarte_pairing_api application user experience This issue is about user experience
Projects
Astarte
Status: Unscheduled
Milestone
v1.2
Development

Successfully merging a pull request may close this issue.

Pairing: allow re-registering devices even if limit is reached Annopaolo/astarte
2 participants
@Annopaolo @davidebriani