Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Payload for server owned interfaces missing the timestamp #785

Open
sorru94 opened this issue May 24, 2023 · 1 comment
Open

Payload for server owned interfaces missing the timestamp #785

sorru94 opened this issue May 24, 2023 · 1 comment
Labels
app:appengine_api This issue or pull request is about astarte_appengine_api application discussion This issue needs to be investigated/discussed (it might be already fixed, invalid or duplicated) user experience This issue is about user experience
Milestone

Comments

@sorru94
Copy link
Contributor

sorru94 commented May 24, 2023

The timestamp seems missing in the payload for a publish on a server-owned interface.

This has been observed in the end-to-end tests for the Astarte device SDK python.
Report from this run could be helpful. The interface org.astarte-platform.python.e2etest.ServerDatastream contains half of the endpoints with explicit_timestamp set to true and half with it set to false.

@rbino
Copy link
Collaborator

rbino commented May 24, 2023

I think the actual underlying issue is that we're accepting explicit_timestamp for server-owned interfaces while there's no actual way of sending an explicit timestamp to them from AppEngine API.
explicit_timestamp was designed to provide devices a way to provide an application-specific timestamp to attach to a piece of data, which could possibly be different from the clock timestamp. Does this make sense for server-owned interfaces too? It's open to discussion, but since in the current state there's no actual way to send explicit timestamps for them, I'd suggest to refute explicit_timestamp on server-owned interfaces so we don't provide false hopes to the users. We can always start accepting it if and when we actually have support for it.

@Annopaolo Annopaolo added discussion This issue needs to be investigated/discussed (it might be already fixed, invalid or duplicated) user experience This issue is about user experience app:appengine_api This issue or pull request is about astarte_appengine_api application labels Oct 3, 2023
@Annopaolo Annopaolo added this to the v1.3 milestone Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:appengine_api This issue or pull request is about astarte_appengine_api application discussion This issue needs to be investigated/discussed (it might be already fixed, invalid or duplicated) user experience This issue is about user experience
Projects
None yet
Development

No branches or pull requests

3 participants