New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

only first newline is truncated from schema description #170

Open

scarf005 opened this issue Jul 2, 2023 · 0 comments · May be fixed by #172

Contributor

scarf005 commented Jul 2, 2023 •

edited

openapi-zod-client/lib/src/getZodiosEndpointDefinitionList.ts

Lines 241 to 244 in f71bfa9

    
           if (options?.withDescription && paramSchema) { 
        
               (paramSchema as SchemaObject).description = (paramItem.description ?? "")?.replace("\n", ""); 
        
           }

as String.prototype.replace replaces at most once, String.prototype.replaceAll needs to be used instead.

however, stripping newlines could cause unexpected behavior. maybe template literal(`) should be used instead?

The text was updated successfully, but these errors were encountered:

scarf005 linked a pull request

that will close this issue

feat: improve multline description handling #172

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment