Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] lsp documentation #697

Closed
chrisgrieser opened this issue Nov 5, 2023 · 7 comments
Closed

[feature] lsp documentation #697

chrisgrieser opened this issue Nov 5, 2023 · 7 comments
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@chrisgrieser
Copy link

Currently, the documentation on how to use ast-grep as LSP is rather sparse. I got it working in nvim, via vim.lsp.start, but commonly, LSPs have settings, initialization options, code actions (fixing stuff), etc. – even if there isn't a lot (yet), knowing that there is not much to configure would be useful.

⭐ Suggestion

  1. Add some documentation on the LSP to the docs.
  2. Add some documentation to sg lsp --help

💻 Use Cases

I create a PR to make it easier to add in the LSP in nvim: neovim/nvim-lspconfig#2880
It works basically, but having being able to potentially configure more stuff could be useful

@chrisgrieser chrisgrieser added the enhancement New feature or request label Nov 5, 2023
@HerringtonDarkholme HerringtonDarkholme added the documentation Improvements or additions to documentation label Nov 8, 2023
@HerringtonDarkholme
Copy link
Member

HerringtonDarkholme commented Nov 8, 2023

Wow! Thanks for your question and contribution to nvim-lspconfig!

LSP now is somewhat crude and does not have configurations.

Appreciate your suggestion on what configuration option can be.
I will investigate them and document them soon~

@0xdevalias
Copy link

0xdevalias commented May 18, 2024

I noticed this issue was closed by this commit:

But was wondering, should the textDocument/didOpen, textDocument/didChange, textDocument/didClose dotpoints in those docs link to something as they did above in #697 (comment) ?

Client capability:

@HerringtonDarkholme
Copy link
Member

added @0xdevalias

@0xdevalias
Copy link

added

@HerringtonDarkholme Not sure if you misread what I said above, or it hasn't been pushed, but that doesn't seem to be the case?

Still points to this commit as the latest, which doesn't have the links I was asking about:

Specifically:

should the textDocument/didOpen, textDocument/didChange, textDocument/didClose dotpoints in those docs link to something

@HerringtonDarkholme
Copy link
Member

ast-grep/ast-grep.github.io@45dd4b1

@0xdevalias
Copy link

@HerringtonDarkholme Awesome, thankyou! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
Development

No branches or pull requests

3 participants