Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved template file to proper location #221

Closed
wants to merge 1 commit into from
Closed

Moved template file to proper location #221

wants to merge 1 commit into from

Conversation

t0rrant
Copy link

@t0rrant t0rrant commented Sep 9, 2019

refactored print macros to print function
changed function names to adhere to PEP8
changed space formatting to adhere to PEP8

Closes: #219
Signed-off-by: Manuel Torrinha manuel.torrinha@tecnico.ulisboa.pt

refactored print macros to print function
changed function names to adhere to PEP8
changed space formatting to adhere to PEP8

Signed-off-by: Manuel Torrinha <manuel.torrinha@tecnico.ulisboa.pt>
@codecov-io
Copy link

Codecov Report

Merging #221 into master will decrease coverage by 0.58%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #221      +/-   ##
==========================================
- Coverage   41.95%   41.37%   -0.59%     
==========================================
  Files          72       73       +1     
  Lines        6461     6552      +91     
==========================================
  Hits         2711     2711              
- Misses       3750     3841      +91
Impacted Files Coverage Δ
flowcraft/templates/renamePE_samtoolsFASTQ.py 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3a670a...a357794. Read the comment docs.

@cimendes
Copy link
Member

cimendes commented Sep 9, 2019

Hi! Thank you for contribution to flowcraft! Unfortunatly moving that rogue file is not that simple :P I'm going to close this PR unmerged but I've started implementing the fix for #219 in a branch. There's at least two components that use this scipt: retrieve_mapped and remove_host. I've updated the template to follow our guidelines and upgraded it to python3, but I haven't tested it. I'll create a PR when I do so.

Best!

Inês

@cimendes cimendes closed this Sep 9, 2019
@t0rrant
Copy link
Author

t0rrant commented Sep 10, 2019

Thank you @cimendes, and sorry for any confusion ^_^

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python3 syntax errors
3 participants