Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merging inspect and report #181

Open
jacarrico opened this issue Dec 12, 2018 · 3 comments
Open

Merging inspect and report #181

jacarrico opened this issue Dec 12, 2018 · 3 comments
Assignees
Labels
discussion enhancement New feature or request

Comments

@jacarrico
Copy link
Collaborator

Using flowcraft repeateadly I arrived to the conclusion that if the report can be only a flag on the inspect mode it would be better and would avoid to have 2 open terminal to get the same result.
What are your opinions?

@ODiogoSilva
Copy link
Collaborator

That could work, but the two services should be kept separate. We could either create a new flowcraft mode (flowcraft one-seeing-eye) that would actually run the two services in parallel and return both links? Or add a flag to each report and inspect to track each one, but that seams less intuitive.

@jacarrico
Copy link
Collaborator Author

jacarrico commented Dec 12, 2018

@ODiogoSilva I agree to keep it separate because the user might want the option not to send results data for a webservice. It returns the inspect link with the button and the popup saying reports are available

and I would keep inspect. Report is a special case of inspecting the results

@cimendes
Copy link
Member

Usually when you already a have a complete analysis you don't return to the insect of the pipeline. It's arguably much more useful to have both services running while a pipeline is still executing. An alternative to the new flowcraft mode is to add a flag to the inspect mode to also launch the report service, in watch mode. Something like flowcraft inspect -m broadcast --report). I'm not against the suggested new mode by any means.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants