-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue in latest version of assemble #9
Comments
@stefanwalther looks like it's passing now. not sure why it was failing before |
OK, I'll check and re-activate again, thx. |
@jonschlinkert: No, actually still the same problem: Note: running it locally also fully works, seems to be an issue with travis, same issue on appveyor: https://ci.appveyor.com/project/stefanwalther/assemble-workshop/build/1.0.13/job/ombo46ncv27phjqr |
These 2 lines are probably causing a circular reference when the context is merged before doing the actual rendering. |
So a deep-copy or clone would the probably do the trick, right? |
No, unfortunately that wasn't the case - I think: Changed from: view.data.articles = app.views.articles;
view.data.pages = app.views.pages; to: view.data.articles = _.clone( app.views.articles );
view.data.pages = _.clone( app.views.pages ); Results: |
you can probably figure out the problem quickly by For debugging, try doing this: app.src('foo').on('error', console.log)
.pipe(bar()).on('error', console.log) and add that |
It looks like the goal is to expose those view collections on the context used in Handlebars when rendering. I think it's a better approach to just set them on app.data({
articles: app.views.articles,
pages: app.views.pages
}); Then remove the Also, it's a good idea to listen for those errors to track down where the error is occurring. As Jon said, it should help track down the issue faster. |
OK, thx again, will give it a new try ;-) |
Hi @doowb, also not works, by following your advice I get: Again, the strange thing is that "my" approach still works on OSX, but not on travis (a pure Linux whatever distribution). Still not idea how to make this test successful. (And I actually use this approach in several of my solutions - so it is quite important for me ;-)) |
|
Hi @jonschlinkert,
can you think of the reason why this is failing:
https://travis-ci.org/assemble/assemble-workshop/jobs/145969664
What did change in recent versions?
Does collection-basic not follow best practices?
Regards
Stefan
The text was updated successfully, but these errors were encountered: