Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating ASReview to Python 3.12 #1689

Closed
taleevenhuis opened this issue Feb 15, 2024 · 4 comments
Closed

Updating ASReview to Python 3.12 #1689

taleevenhuis opened this issue Feb 15, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@taleevenhuis
Copy link

In December, last year, I found out that not all the models were working fine, especially Sentence BERT in combination with fully connected CNN. My Python Version was at that moment 3.12.

One of the ASReview-members noticed that this model works best with Python 3.11. When he succeeded to reinstall Python 3.11, Sentence BERT in combination with fully connected CNN, worked smoothly again.
One of the researchers I'm helping to work with ASReview, noticed the same trouble SBERT and CNN and his Python version is also 3.12.

Is it possible to update ASReview, that SBERT and CNN also works at Python 3.12?

@taleevenhuis taleevenhuis added the bug Something isn't working label Feb 15, 2024
@jteijema
Copy link
Member

jteijema commented Feb 19, 2024

Hi @taleevenhuis

The issue with python 3.12 lies not with ASReview itself, but with one of the packages ASReview uses. Tensorflow, Keras and transformers all have their separate issues with this. I can only assume the developers of those packages are working on new versions, but this is sadly not something we can solve!

Often newer versions of software have better performance, therefore it's understandable to want to use the latest version, however this is not exactly the case with python. Python adds new features, but as long as those features aren't used, I daresay there is nothing to be gained by using 3.12 :)

^JT

@taleevenhuis
Copy link
Author

Thanks voor your clear reply, Jelle! I will tell the researcher to return to Python 3.11.

@J535D165 J535D165 pinned this issue Mar 6, 2024
@J535D165
Copy link
Member

Tensorflow now supports Python 3.12. Everything should work as expected again.

@taleevenhuis
Copy link
Author

I'm very sorry Jonathan. Last week, a researcher from the Hogeschool Utrecht, still had a problem working with the combination SBERT en Neural Network. See the added picture!
Error SBERT-NN

The researcher works with Python 3.12.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants